Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312190: Fix c++11-narrowing warnings in hotspot code #14907

Closed
wants to merge 2 commits into from

Conversation

djelinski
Copy link
Member

@djelinski djelinski commented Jul 17, 2023

This patch fixes compilation warnings produced by Clang when compiling on Windows.

Clang emulates MSVC behavior and uses int for enumeration types that do not explicitly specify the underlying type. This patch sets an explicit underlying type for 3 enumerations to fix the warnings.

See Microsoft's documentation of Zc:enumTypes for more information.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312190: Fix c++11-narrowing warnings in hotspot code (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14907/head:pull/14907
$ git checkout pull/14907

Update a local copy of the PR:
$ git checkout pull/14907
$ git pull https://git.openjdk.org/jdk.git pull/14907/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14907

View PR using the GUI difftool:
$ git pr show -t 14907

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14907.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2023

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8312190 8312190: Fix c++11-narrowing warnings in hotspot code Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@djelinski The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Jul 17, 2023
@djelinski djelinski marked this pull request as ready for review July 18, 2023 04:33
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 18, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 18, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.

Thanks.

@@ -245,7 +245,7 @@ do {


// types of VM error - originally in vmError.hpp
enum VMErrorType {
enum VMErrorType : unsigned int {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why 'unsigned int' when the other changes are uint?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uint is not available in this header file, and I didn't want to add includes.

@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312190: Fix c++11-narrowing warnings in hotspot code

Reviewed-by: dholmes, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • b4dce0d: 8310814: Clarify the targetName parameter of Lookup::findClass
  • 9905f75: 8311040: JFR: RecordedThread::getOSThreadId() should return -1 if thread is virtual
  • 1dfb0fb: 8311188: Simplify and modernize equals and hashCode in java.text
  • 1fc726a: 8312163: Crash in dominance check when compiling unnamed patterns
  • b20dc1e: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
  • 4b9ec82: 8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest
  • 8ec136e: 8312072: Deprecate for removal the -Xnoagent option
  • fbe51e3: 8312127: FileDescriptor.sync should temporarily increase parallelism
  • 201e3bc: 8291065: Creating a VarHandle for a static field triggers class initialization
  • a53345a: 8287061: Support for rematerializing scalar replaced objects participating in allocation merges
  • ... and 14 more: https://git.openjdk.org/jdk/compare/37ca9024ef59d99cae0bd7e25b2e6d3c1e085f97...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 18, 2023
@dholmes-ora
Copy link
Member

Of course please ensure all our CI builds are successful too!

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@djelinski
Copy link
Member Author

Mach5 came back clean. Thanks for the reviews!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2023

Going to push as commit f677793.
Since your change was applied there have been 43 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2023
@openjdk openjdk bot closed this Jul 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2023
@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@djelinski Pushed as commit f677793.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp
Copy link
Contributor

coleenp commented Jul 28, 2023

@djelinski Please review PR #15056 and/or test with your compiler, please.

@djelinski djelinski deleted the narrowing branch September 27, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated
4 participants