Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8312195: Changes in JDK-8284493 use wrong copyright syntax #14908

Closed
wants to merge 1 commit into from

Conversation

jddarcy
Copy link
Member

@jddarcy jddarcy commented Jul 17, 2023

Update to conform to accepted syntax.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312195: Changes in JDK-8284493 use wrong copyright syntax (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14908/head:pull/14908
$ git checkout pull/14908

Update a local copy of the PR:
$ git checkout pull/14908
$ git pull https://git.openjdk.org/jdk.git pull/14908/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14908

View PR using the GUI difftool:
$ git pr show -t 14908

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14908.diff

@jddarcy
Copy link
Member Author

jddarcy commented Jul 17, 2023

/integrate

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2023

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312195: Changes in JDK-8284493 use wrong copyright syntax

Reviewed-by: rriggs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

Going to push as commit 295ae11.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2023
@openjdk openjdk bot closed this Jul 17, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@jddarcy Pushed as commit 295ae11.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@jddarcy The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 17, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 17, 2023

Webrevs

@jddarcy jddarcy deleted the JDK-8312195 branch October 17, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants