Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) #14914

Closed

Conversation

backwaterred
Copy link
Contributor

@backwaterred backwaterred commented Jul 17, 2023

Solves the issue by searching /proc/<pid>/map for the map after an EINVAL. If the map is marked MAP_PRIVATE then EINVAL is ignored.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Integration blocker

 ⚠️ Dependency #14904 must be integrated first

Issue

  • JDK-8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14914/head:pull/14914
$ git checkout pull/14914

Update a local copy of the PR:
$ git checkout pull/14914
$ git pull https://git.openjdk.org/jdk.git pull/14914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14914

View PR using the GUI difftool:
$ git pr show -t 14914

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14914.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2023

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into pr/14904 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8309475 8309475: [aix] Test java/foreign/TestByteBuffer.java fails: a problem with msync Jul 17, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 17, 2023
@openjdk
Copy link

openjdk bot commented Jul 17, 2023

@backwaterred The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jul 17, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 17, 2023

Webrevs

@backwaterred backwaterred marked this pull request as draft July 17, 2023 23:35
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jul 17, 2023
@AlanBateman
Copy link
Contributor

AlanBateman commented Jul 18, 2023

This is a bit messy and very inconsistent with the existing code. I think it would help to move this to src/java.base/aix.

@backwaterred backwaterred changed the title 8309475: [aix] Test java/foreign/TestByteBuffer.java fails: a problem with msync 8309475 Jul 18, 2023
@openjdk openjdk bot changed the title 8309475 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix) Jul 18, 2023
@backwaterred
Copy link
Contributor Author

Closing in favour of another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
nio nio-dev@openjdk.org
2 participants