JDK-8311592 ECKeySizeParameterSpec causes too many exceptions on third party providers

[ascarpino]

Hi,

This fix eliminates needless exceptions each time the EC key size is obtained through AlgorithmParameters on third party providers. These providers throw an InvalidParameterSpecException as sun.security.util.KeyUtil.getKey() sends an internal sun.security.util.ECKeySizeParameterSpec. The exception is properly handled, but the number of exceptions becomes excessive with TLS.
Calling ECKeySizeParameterSpec only with SunEC resolves this issue.

Thanks

Tony

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers (Bug - P2)

Reviewers

• Hai-May Chao (@haimaychao - Committer)
• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14916/head:pull/14916
$ git checkout pull/14916

Update a local copy of the PR:
$ git checkout pull/14916
$ git pull https://git.openjdk.org/jdk.git pull/14916/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14916

View PR using the GUI difftool:
$ git pr show -t 14916

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14916.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back ascarpino! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@ascarpino The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0abc9a2e)

[haimaychao]

LGTM

[openjdk]

@ascarpino This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers

Reviewed-by: hchao, valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

• d0761c1: 8312077: Fix signed integer overflow, final part
• 2bdfa83: 8262742: (fs) Add Path::resolve with varargs string
• 8008e27: 8308903: Print detailed info for Java objects in -Xlog:cds+map
• d8f2e9a: 8310530: PipedOutputStream.flush() accesses sink racily
• fac9f88: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
• d5c6b0d: 8311261: [AIX] TestAlwaysPreTouchStacks.java fails due to java.lang.RuntimeException: Did not find expected NMT output
• d1cc278: 8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [i4] but found [I4]
• 3caf64e: 8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134"
• 298dda4: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
• 7dd4799: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers
• ... and 82 more: https://git.openjdk.org/jdk/compare/e73796879299c6170b63edb998439db4764ceae0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[ascarpino]

/integrate

[openjdk]

Going to push as commit e554fde.
Since your change was applied there have been 99 commits pushed to the master branch:

• 9606cbc: 8312524: [JVMCI] serviceability/dcmd/compiler/CompilerQueueTest.java fails
• 91fe032: 8312818: Incorrect format specifier in a HttpClient log message
• bd09880: 8312512: sspi.cpp avoid some NULL checks related to free and delete
• b35ccb2: 8312533: JFR: No message for JFR.view when data is missing
• ea067fc: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
• 9999838: 8311646: ZGC: LIR_OpZStoreBarrier::_info shadows LIR_Op::_info
• d63bff6: 8312578: Redundant javadoc in X400Address
• d0761c1: 8312077: Fix signed integer overflow, final part
• 2bdfa83: 8262742: (fs) Add Path::resolve with varargs string
• 8008e27: 8308903: Print detailed info for Java objects in -Xlog:cds+map
• ... and 89 more: https://git.openjdk.org/jdk/compare/e73796879299c6170b63edb998439db4764ceae0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@ascarpino Pushed as commit e554fde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.