JDK-8312203: Improve specification of Array.newInstance

[jddarcy]

Change one overload of java.lang.reflect.Array.newInstance to have an @implSpec of calling the other method.

I choose not to use a snippet tag here is this code is semantically only one line and doesn't need to be cut-and-pasted.

As adding an @implSpec is technically a (small) specification change, please also review the CSR:

https://bugs.openjdk.org/browse/JDK-8312208

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Change requires CSR request JDK-8312208 to be approved
• Commit message must refer to an issue

Issues

• JDK-8312203: Improve specification of Array.newInstance (Bug - P4)
• JDK-8312208: Improve specification of Array.newInstance (CSR)

Reviewers

• Brian Burkhalter (@bplb - Reviewer)
• Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14917/head:pull/14917
$ git checkout pull/14917

Update a local copy of the PR:
$ git checkout pull/14917
$ git pull https://git.openjdk.org/jdk.git pull/14917/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14917

View PR using the GUI difftool:
$ git pr show -t 14917

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14917.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back darcy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jddarcy The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fd458c5a)

[liach]

Snippet is not just for cut-and-paste; it can also save us a <blockquote> tag as well, and syntax highlight support in IDEs.

[jddarcy]

With the concession that more of the <blockquote><pre>...</pre></blockquote> blocks still in the JDK should be converted to snippets, I don't think that all of them should necessarily be converted.

Having done a few snippet conversions myself (JDK-8287838, JDK-8289399, JDK-8289775, JDK-8308987), I don't think this particular one is justified as a snippet.

[bplb]

CSR and PR look fine.

[openjdk]

@jddarcy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312203: Improve specification of Array.newInstance

Reviewed-by: bpb, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• b4dce0d: 8310814: Clarify the targetName parameter of Lookup::findClass
• 9905f75: 8311040: JFR: RecordedThread::getOSThreadId() should return -1 if thread is virtual
• 1dfb0fb: 8311188: Simplify and modernize equals and hashCode in java.text
• 1fc726a: 8312163: Crash in dominance check when compiling unnamed patterns
• b20dc1e: 8310629: java/security/cert/CertPathValidator/OCSP/OCSPTimeout.java fails with RuntimeException Server not ready
• 4b9ec82: 8310355: Move the stub test from initialize_final_stubs() to test/hotspot/gtest
• 8ec136e: 8312072: Deprecate for removal the -Xnoagent option
• fbe51e3: 8312127: FileDescriptor.sync should temporarily increase parallelism
• 201e3bc: 8291065: Creating a VarHandle for a static field triggers class initialization
• a53345a: 8287061: Support for rematerializing scalar replaced objects participating in allocation merges
• ... and 5 more: https://git.openjdk.org/jdk/compare/f975be44a86879e1079a0066203b49d59b7a1167...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jddarcy]

/integrate

[openjdk]

Going to push as commit e5ecbff.
Since your change was applied there have been 31 commits pushed to the master branch:

• c2f421b: 8311541: JavaThread::print_jni_stack doesn't support native stacks on all platforms
• e31df3a: 6211126: ICC_ColorSpace.toCIEXYZ(float[]): NPE is not specified
• 7d9f5af: 6211202: ColorSpace.getInstance(int): IAE is not specified
• 28c4d19: 8311902: Concurrency regression in the PBKDF2 key impl of SunJCE provider
• 5c4623b: 8308682: Enhance AES performance
• cb5f1b7: 8303376: Better launching of JDI
• 925138a: 8296565: Enhanced archival support
• 889c663: 8305312: Enhanced path handling
• be70bc1: 8294323: Improve Shared Class Data
• ecd0bc1: 8300596: Enhance Jar Signature validation
• ... and 21 more: https://git.openjdk.org/jdk/compare/f975be44a86879e1079a0066203b49d59b7a1167...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jddarcy Pushed as commit e5ecbff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.