Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312259: StatusResponseManager unused code clean up #14924

Closed
wants to merge 4 commits into from

Conversation

XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Jul 18, 2023

Hi,

May I have the code cleanup update reviewed? With this update, the unused code in StatusResponseManager.java will be removed.

Thanks,
Xuelei


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312259: StatusResponseManager unused code clean up (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14924/head:pull/14924
$ git checkout pull/14924

Update a local copy of the PR:
$ git checkout pull/14924
$ git pull https://git.openjdk.org/jdk.git pull/14924/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14924

View PR using the GUI difftool:
$ git pr show -t 14924

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14924.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2023

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jul 18, 2023
@XueleiFan XueleiFan marked this pull request as ready for review July 18, 2023 19:14
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 18, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 18, 2023

Webrevs

}

static final StaplingParameters processStapling(
static StaplingParameters processStapling(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though a static method is implicitly final, the final keyword does prevent subclasses from inadvertently using the same method signature.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I got what you meant and will add the final keyword back. Thanks!

@XueleiFan
Copy link
Member Author

ping ...

@mcpowers
Copy link
Contributor

I'll look at it again.

Copy link
Contributor

@mcpowers mcpowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I would have gone to the trouble to remove methods used by tests, but I understand your motivation. StatusResponseManager is definitely improved.

@@ -95,6 +102,7 @@ public static void main(String[] args) throws Exception {
rootOcsp.stop();
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: added space

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review. I just removed the space.

@seanjmullan
Copy link
Member

I think @jnimeh should review this, as I think these methods were added when implementing OCSP Stapling, and it would be good for him to make sure they are no longer needed..

@XueleiFan
Copy link
Member Author

I think @jnimeh should review this, as I think these methods were added when implementing OCSP Stapling, and it would be good for him to make sure they are no longer needed..

@jnimeh Did you have a chance to have a look at this update?

@jnimeh
Copy link
Member

jnimeh commented Aug 2, 2023

@XueleiFan I will have time to review this today.

Copy link
Member

@jnimeh jnimeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The removal of these methods is fine. Many of these were in there to support a different planned approach to populating the SRM's cache, but we went with a simpler approach when it was implemented in JDK 9. If we ever decide to implement a scheduler-based refresh we can always add the methods that we need back.

@openjdk
Copy link

openjdk bot commented Aug 7, 2023

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312259: StatusResponseManager unused code clean up

Reviewed-by: mpowers, jnimeh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 209 new commits pushed to the master branch:

  • 4726960: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • bbbfa21: 8313880: Incorrect copyright header in jdk/java/foreign/TestFree.java after JDK-8310643
  • 0bb6af3: 8313791: Fix just zPage.inline.hpp and xPage.inline.hpp
  • 4b192a8: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly
  • 0b4387e: 8310643: Misformatted copyright messages in FFM
  • 538f955: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • 226cdc6: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • dc01604: 8305636: Expand and clean up predicate classes and move them into separate files
  • a38fdaf: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.
  • c1f4595: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem
  • ... and 199 more: https://git.openjdk.org/jdk/compare/b4dce0d62479c2494c02570a60319cb1a5932940...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 7, 2023
@XueleiFan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 10, 2023

Going to push as commit 79be8d9.
Since your change was applied there have been 259 commits pushed to the master branch:

  • 1875b28: 8314061: [JVMCI] DeoptimizeALot stress logic breaks deferred barriers
  • bd1b942: 8313905: Checked_cast assert in CDS compare_by_loader
  • 9b53251: 8313654: Test WaitNotifySuspendedVThreadTest.java timed out
  • e7c83ea: 8312194: test/hotspot/jtreg/applications/ctw/modules/jdk_crypto_ec.java cannot handle empty modules
  • 23fe2ec: 8313616: support loading library members on AIX in os::dll_load
  • f47767f: 8313882: Fix -Wconversion warnings in runtime code
  • 0cb9ab0: 8313239: InetAddress.getCanonicalHostName may return ip address if reverse lookup fails
  • 028b3ae: 8313874: JNI NewWeakGlobalRef throws exception for null arg
  • 83adaf5: 8313421: [JVMCI] avoid locking class loader in CompilerToVM.lookupType
  • 35b60f9: 8298095: Refine implSpec for SegmentAllocator
  • ... and 249 more: https://git.openjdk.org/jdk/compare/b4dce0d62479c2494c02570a60319cb1a5932940...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 10, 2023
@openjdk openjdk bot closed this Aug 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2023
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@XueleiFan Pushed as commit 79be8d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@XueleiFan XueleiFan deleted the JDK-8312259 branch August 10, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
4 participants