8312414: Make java.util.ServiceLoader.LANG_ACCESS final

[turbanoff]

Found opportunity to make static ServiceLoader.LANG_ACCESS field final.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312414: Make java.util.ServiceLoader.LANG_ACCESS final (Enhancement - P5)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)
• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14926/head:pull/14926
$ git checkout pull/14926

Update a local copy of the PR:
$ git checkout pull/14926
$ git pull https://git.openjdk.org/jdk.git pull/14926/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14926

View PR using the GUI difftool:
$ git pr show -t 14926

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14926.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ef8e2044)

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312414: Make java.util.ServiceLoader.LANG_ACCESS final

Reviewed-by: alanb, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

• 37c756a: 8305506: Add support for fractional values of SafepointTimeoutDelay
• dfe764e: 8309032: jpackage does not work for module projects unless --module-path is specified
• 61ab270: 8310835: Address gaps in -Xlint:serial checks
• 5d57b5c: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance
• 71cac8c: 8311663: Additional refactoring of Locale tests to JUnit
• aa23fd9: 8311879: SA ClassWriter generates invalid invokedynamic code
• 6f66213: 8312014: [s390x] TestSigInfoInHsErrFile.java Failure
• b5b6f4e: 8312164: Refactor Arrays.hashCode for long, boolean, double, float, and Object arrays
• 14cf035: 8302987: Add uniform and spatially equidistributed bounded double streams to RandomGenerator
• d1c788c: 8312392: ARM32 build broken since 8311035
• ... and 25 more: https://git.openjdk.org/jdk/compare/b4dce0d62479c2494c02570a60319cb1a5932940...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[turbanoff]

/integrate

[openjdk]

Going to push as commit f4ba7b2.
Since your change was applied there have been 56 commits pushed to the master branch:

• d55d7e8: 8136895: Writer not closed with disk full error, file resource leaked
• 8042a50: 8309305: sun/security/ssl/SSLSocketImpl/BlockedAsyncClose.java fails with jtreg test timeout
• 84b325b: 8312182: THPs cause huge RSS due to thread start timing issue
• 842d632: 8227229: Deprecate the launcher -Xdebug/-debug flags that have not done anything since Java 6
• 9e4fc56: 8293114: JVM should trim the native heap
• 59f66a3: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086
• 8cd43bf: 8312474: JFR: Improve logging to diagnose event stream timeout
• 3e8f1eb: 8311976: Inconsistency in usage of CITimeVerbose to generate compilation logs
• d4aacdb: 8306136: [vectorapi] Intrinsics of VectorMask.laneIsSet()
• 783de32: 8300051: assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event controller, JVM TI environments must exist
• ... and 46 more: https://git.openjdk.org/jdk/compare/b4dce0d62479c2494c02570a60319cb1a5932940...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit f4ba7b2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.