Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8312392: ARM32 build broken since 8311035 #14934

Closed
wants to merge 1 commit into from

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jul 19, 2023

Trivial fix.

/shared/projects/openjdk/jdk-jdk/source/src/hotspot/share/cds/metaspaceShared.cpp:1256: error: undefined reference to 'CompressedKlassPointers::is_valid_base(unsigned char*)'

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312392: ARM32 build broken since 8311035 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14934/head:pull/14934
$ git checkout pull/14934

Update a local copy of the PR:
$ git checkout pull/14934
$ git pull https://git.openjdk.org/jdk.git pull/14934/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14934

View PR using the GUI difftool:
$ git pr show -t 14934

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14934.diff

Webrev

Link to Webrev Comment

@tstuefe tstuefe marked this pull request as ready for review July 19, 2023 13:37
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 19, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 19, 2023
@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 19, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 19, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312392: ARM32 build broken since 8311035

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 19, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Jul 19, 2023

Thanks @shipilev !

/integrate

@openjdk
Copy link

openjdk bot commented Jul 19, 2023

Going to push as commit d1c788c.
Since your change was applied there has been 1 commit pushed to the master branch:

  • c119037: 8311971: SA's ConstantPool.java uses incorrect computation to read long value in the constant pool

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 19, 2023
@openjdk openjdk bot closed this Jul 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 19, 2023
@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@tstuefe Pushed as commit d1c788c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tstuefe tstuefe deleted the JDK-8312392-arm-build-broken branch July 25, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants