Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8300051: assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event controller, JVM TI environments must exist #14945

Closed
wants to merge 1 commit into from

Conversation

sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Jul 20, 2023

This problem is encountered when a JVMTI agent is loaded into running VM. The JvmtiExport::get_jvmti_interface() is called from the agent's Agent_OnAttach entrypoint. To support virtual threads it enables JVMTI notifications from the VirtualThread class with a call to:
JvmtiEnvBase::enable_virtual_threads_notify_jvmti().
The problem is that there is no JVMTI environments at this point yet. This assert is hit when a virtual thread is created concurrently after the JVMTI notifications have been enabled but the requested JVMTI environment has not been created yet.
The fix is to create a JVMTI env first and only then to enable the JVMTI notifications.

This issue is very hard to reproduce. I had to use some tricks with adding os::naked_short_nanosleep() and also by refactoring the test VThreadTLSTest.java. At least, I was able to verify this test does not fail with my fix anymore.

Testing:

  • submitted hundreds of VThreadTLSTest.java mach5 runs on several platforms in the fastdebug mode
  • in progress: mach5 tiers 1-6

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300051: assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event controller, JVM TI environments must exist (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14945/head:pull/14945
$ git checkout pull/14945

Update a local copy of the PR:
$ git checkout pull/14945
$ git pull https://git.openjdk.org/jdk.git pull/14945/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14945

View PR using the GUI difftool:
$ git pr show -t 14945

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14945.diff

Webrev

Link to Webrev Comment

…enter event controller, JVM TI environments must exist
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2023

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@sspitsyn The following labels will be automatically applied to this pull request:

  • hotspot
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Jul 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 20, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems a reasonable solution.

Thanks.

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300051: assert(JvmtiEnvBase::environments_might_exist()) failed: to enter event controller, JVM TI environments must exist

Reviewed-by: dholmes, pchilanomate

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • b772e67: 8312395: Improve assertions in growableArray
  • 9fa944e: 8312019: Simplify and modernize java.util.BitSet.equals
  • fe41910: 8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS
  • 8d29329: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList
  • 94eb44b: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 3283328: 8311130: AArch64: Sync SVE related CPU features with VM options
  • a742767: 8312246: NPE when HSDB visits bad oop
  • 37c756a: 8305506: Add support for fractional values of SafepointTimeoutDelay

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2023
Copy link
Contributor

@pchilano pchilano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@sspitsyn
Copy link
Contributor Author

David and Patricio, thank you for quick review!

@sspitsyn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

Going to push as commit 783de32.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 4e8f331: 8312443: sun.security should use toLowerCase(Locale.ROOT)
  • d7b9416: 8199149: Improve the exception message thrown by VarHandle of unsupported operation
  • 354c660: 8307185: pkcs11 native libraries make JNI calls into java code while holding GC lock
  • bae2247: 8308591: JLine as the default Console provider
  • b772e67: 8312395: Improve assertions in growableArray
  • 9fa944e: 8312019: Simplify and modernize java.util.BitSet.equals
  • fe41910: 8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS
  • 8d29329: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList
  • 94eb44b: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 3283328: 8311130: AArch64: Sync SVE related CPU features with VM options
  • ... and 2 more: https://git.openjdk.org/jdk/compare/dfe764e3f85784752d69fd51306644732e808d38...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 20, 2023
@openjdk openjdk bot closed this Jul 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@sspitsyn Pushed as commit 783de32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn
Copy link
Contributor Author

/backport jdk21

@openjdk
Copy link

openjdk bot commented Jul 21, 2023

@sspitsyn the backport was successfully created on the branch sspitsyn-backport-783de32b in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 783de32b from the openjdk/jdk repository.

The commit being backported was authored by Serguei Spitsyn on 20 Jul 2023 and was reviewed by David Holmes and Patricio Chilano Mateo.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git sspitsyn-backport-783de32b:sspitsyn-backport-783de32b
$ git checkout sspitsyn-backport-783de32b
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git sspitsyn-backport-783de32b

@sspitsyn sspitsyn deleted the b4 branch July 25, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
3 participants