-
Notifications
You must be signed in to change notification settings - Fork 6.2k
6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left #14949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back tr! A progress list of the required criteria for merging this PR into |
|
@TejeshR13 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/jdk/javax/swing/JFileChooser/FCPopupMenuOrientationTest.java
Outdated
Show resolved
Hide resolved
test/jdk/javax/swing/JFileChooser/FCPopupMenuOrientationTest.java
Outdated
Show resolved
Hide resolved
|
@TejeshR13 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 710 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit ab821aa.
Your commit was automatically rebased without conflicts. |
|
@TejeshR13 Pushed as commit ab821aa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Popup menu is created on mouse click, hence the orientation for FileChooser won't apply to the popup menu created. Hence the fix address the issue by applying the FileChooser orientation when it is created on mouse operation (Right Click).
The test does not apply to Motif and Aqua Look And Feel since right click is not supported on filePane of FileChooser, hence it is skipped. The fix is tested in CI and it is green.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14949/head:pull/14949$ git checkout pull/14949Update a local copy of the PR:
$ git checkout pull/14949$ git pull https://git.openjdk.org/jdk.git pull/14949/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 14949View PR using the GUI difftool:
$ git pr show -t 14949Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14949.diff
Webrev
Link to Webrev Comment