Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS #14956

Closed

Conversation

azvegint
Copy link
Member

@azvegint azvegint commented Jul 20, 2023

This test fails in macOS 13, making the CI noise.

java.lang.RuntimeException:
DisplayMode(1920 x 1080 x 32bpp x 60)
Pixel 0: Expected ffff0000, got ff000000 at 0
at CycleDMImage.main(CycleDMImage.java:296)
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
at java.base/java.lang.reflect.Method.invoke(Method.java:580)
at com.sun.javatest.regtest.agent.MainWrapper$MainTask.run(MainWrapper.java:138)
at java.base/java.lang.Thread.run(Thread.java:1570)

JavaTest Message: Test threw exception: java.lang.RuntimeException:
DisplayMode(1920 x 1080 x 32bpp x 60)
Pixel 0: Expected ffff0000, got ff000000 at 0
JavaTest Message: shutting down test


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14956/head:pull/14956
$ git checkout pull/14956

Update a local copy of the PR:
$ git checkout pull/14956
$ git pull https://git.openjdk.org/jdk.git pull/14956/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14956

View PR using the GUI difftool:
$ git pr show -t 14956

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14956.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2023

👋 Welcome back azvegint! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@azvegint
Copy link
Member Author

/label client

@openjdk openjdk bot added rfr Pull request is ready for review client client-libs-dev@openjdk.org labels Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@azvegint
The client label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 20, 2023

Webrevs

@azvegint
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@azvegint This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312459: Problem list java/awt/GraphicsDevice/DisplayModes/CycleDMImage.java for macOS

Reviewed-by: psadhukhan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 8d29329: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList
  • 94eb44b: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 3283328: 8311130: AArch64: Sync SVE related CPU features with VM options
  • a742767: 8312246: NPE when HSDB visits bad oop
  • 37c756a: 8305506: Add support for fractional values of SafepointTimeoutDelay
  • dfe764e: 8309032: jpackage does not work for module projects unless --module-path is specified
  • 61ab270: 8310835: Address gaps in -Xlint:serial checks
  • 5d57b5c: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

Going to push as commit fe41910.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 8d29329: 8312320: Remove javax/rmi/ssl/SSLSocketParametersTest.sh from ProblemList
  • 94eb44b: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 3283328: 8311130: AArch64: Sync SVE related CPU features with VM options
  • a742767: 8312246: NPE when HSDB visits bad oop
  • 37c756a: 8305506: Add support for fractional values of SafepointTimeoutDelay
  • dfe764e: 8309032: jpackage does not work for module projects unless --module-path is specified
  • 61ab270: 8310835: Address gaps in -Xlint:serial checks
  • 5d57b5c: 6983726: Reimplement MethodHandleProxies.asInterfaceInstance

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 20, 2023
@openjdk openjdk bot closed this Jul 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@azvegint Pushed as commit fe41910.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mrserb
Copy link
Member

mrserb commented Jul 20, 2023

Both bugs mentioned in the problemlist do not have any references/logs about macos x64 please attach it.

@azvegint
Copy link
Member Author

Both bugs mentioned in the problemlist do not have any references/logs about macos x64 please attach it.

It does not differ from the jtr file from windows attached to 7099223, but I added in a comment.
As for the 8274106, I have no logs for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants