-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8257438: Avoid adding duplicate values into extendedKeyCodesSet #1496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257438: Avoid adding duplicate values into extendedKeyCodesSet #1496
Conversation
👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into |
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/issue add JDK-8257438 |
@mrserb Only the author (@turbanoff) is allowed to issue the |
The bug was filed for this PR, please type the command above to refer to that bug. |
/issue add JDK-8257438 |
@turbanoff The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated. |
|
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 98 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@turbanoff |
/sponsor |
@mrserb @turbanoff Since your change was applied there have been 107 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit f83fd4a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Looks like extended key codes set was filled with synonyms
https://wiki.linuxquestions.org/wiki/List_of_Keysyms_Recognised_by_Xmodmap
0x10006cc
is a Farsi_yeh and also deprecated synonym Arabic_farsi_yeh0x1000589
is an Armenian_full_stop and also deprecated synonym Armenian_verjaket0x100055d
is an Armenian_separation_mark and also deprecated synonym Armenian_but0x100055b
is an Armenian_accent and also deprecated synonym Armenian_shesht0x100055e
is an Armenian_question and also deprecated synonym Armenian_paruykFound by IntelliJ IDEA inspection
Java | Probable bugs | Overwritten Map key or Set element
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1496/head:pull/1496
$ git checkout pull/1496