Skip to content

8257438: Avoid adding duplicate values into extendedKeyCodesSet #1496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Nov 28, 2020

Looks like extended key codes set was filled with synonyms
https://wiki.linuxquestions.org/wiki/List_of_Keysyms_Recognised_by_Xmodmap
0x10006cc is a Farsi_yeh and also deprecated synonym Arabic_farsi_yeh
0x1000589 is an Armenian_full_stop and also deprecated synonym Armenian_verjaket
0x100055d is an Armenian_separation_mark and also deprecated synonym Armenian_but
0x100055b is an Armenian_accent and also deprecated synonym Armenian_shesht
0x100055e is an Armenian_question and also deprecated synonym Armenian_paruyk

Found by IntelliJ IDEA inspection Java | Probable bugs | Overwritten Map key or Set element


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8257438: Avoid adding duplicate values into extendedKeyCodesSet

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1496/head:pull/1496
$ git checkout pull/1496

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2020

👋 Welcome back turbanoff! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 28, 2020

@turbanoff The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the awt client-libs-dev@openjdk.org label Nov 28, 2020
@mrserb
Copy link
Member

mrserb commented Nov 30, 2020

/issue add JDK-8257438

@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@mrserb Only the author (@turbanoff) is allowed to issue the /issue command.

@mrserb
Copy link
Member

mrserb commented Nov 30, 2020

The bug was filed for this PR, please type the command above to refer to that bug.

@turbanoff
Copy link
Member Author

/issue add JDK-8257438

@openjdk openjdk bot changed the title [PATCH] Avoid adding duplicate values into extendedKeyCodesSet 8257438: Avoid adding duplicate values into extendedKeyCodesSet Nov 30, 2020
@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@turbanoff The primary solved issue for a PR is set through the PR title. Since the current title does not contain an issue reference, it will now be updated.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 3, 2020

⚠️ @turbanoff the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout remove_duplicate_keycodes_in_ExtendedKeyCodes
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

@openjdk
Copy link

openjdk bot commented Dec 3, 2020

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257438: Avoid adding duplicate values into extendedKeyCodesSet

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 98 new commits pushed to the master branch:

  • 55f5542: 8026976: ECParameters, Point does not match field size
  • d3f3c32: 8255742: PrintInlining as compiler directive doesn't print virtual calls
  • 6c9482e: 8257561: Some code is not vectorized after 8251925 and 8250607
  • 70517c8: 8257642: CipherByteBufferOverwriteTest copyright issue
  • e836396: 8257436: [aarch64] Regressions in ArrayCopyUnalignedDst.testByte/testChar for 65-78 bytes when UseSIMDForMemoryOps is on
  • b170c83: 8257591: Remove suppression of record preview related warnings in java.lang
  • 66a2e70: 8255845: Memory leak in imageFile.cpp
  • fa58671: 8257020: [JVMCI] enable a JVMCICompiler to specify which GCs it supports
  • 129c377: 8257594: C2 compiled checkcast of non-null object triggers endless deoptimization/recompilation cycle
  • e4497c9: 8256718: Obsolete the long term deprecated and aliased Trace flags
  • ... and 88 more: https://git.openjdk.java.net/jdk/compare/c93f0a07c4088ec6c393324e49f32e330f4a58a5...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 3, 2020
@turbanoff
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 3, 2020
@openjdk
Copy link

openjdk bot commented Dec 3, 2020

@turbanoff
Your change (at version 43baa5e) is now ready to be sponsored by a Committer.

@mrserb
Copy link
Member

mrserb commented Dec 3, 2020

/sponsor

@openjdk openjdk bot closed this Dec 3, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 3, 2020
@openjdk
Copy link

openjdk bot commented Dec 3, 2020

@mrserb @turbanoff Since your change was applied there have been 107 commits pushed to the master branch:

  • 37c7835: 8257673: Build fails without shenandoahgc after JDK-8257563
  • f0b1194: 8235784: java/lang/invoke/VarHandles/VarHandleTestByteArrayAsInt.java fails due to timeout with fastdebug bits
  • 36209b7: 8257547: Handle multiple prereqs on the same line in deps files
  • c5b32b3: 8256808: com/sun/jdi/CatchAllTest.java failed with "NullPointerException: Cannot invoke "lib.jdb.Jdb.log(String)" because "this.jdb" is null"
  • 8526947: 6508941: java.awt.Desktop.open causes VM to crash with video files sporadically
  • 7c7facc: 8257701: Shenandoah: objArrayKlass metadata is not marked with chunked arrays
  • 2b73f99: 8228615: Optional.empty doc should suggest using isEmpty
  • 805d058: 8254699: Suboptimal PreTouchParallelChunkSize defaults and limits
  • e29ee5b: 8257641: Shenandoah: Query is_at_shenandoah_safepoint() from control thread should return false
  • 55f5542: 8026976: ECParameters, Point does not match field size
  • ... and 97 more: https://git.openjdk.java.net/jdk/compare/c93f0a07c4088ec6c393324e49f32e330f4a58a5...master

Your commit was automatically rebased without conflicts.

Pushed as commit f83fd4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@turbanoff turbanoff deleted the remove_duplicate_keycodes_in_ExtendedKeyCodes branch December 5, 2020 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants