Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) #14963

Closed

Conversation

backwaterred
Copy link
Contributor

@backwaterred backwaterred commented Jul 20, 2023

This change is as an alternate solution to my original proposal for JDK-8312180.

Suggested by @tstuefe.

This change matches the return value of Bits.pageSize with the system page size (which is not currently true on AIX).

These tests are upstream of my target test (TestByteBuffer) and results are encouraging. Tier1 testing in ongoing for this change passes with flying colours.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14963/head:pull/14963
$ git checkout pull/14963

Update a local copy of the PR:
$ git checkout pull/14963
$ git pull https://git.openjdk.org/jdk.git pull/14963/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14963

View PR using the GUI difftool:
$ git pr show -t 14963

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14963.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 20, 2023

👋 Welcome back tsteele! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8312180 8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix) Jul 20, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@backwaterred The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 20, 2023

Webrevs

@backwaterred backwaterred marked this pull request as draft July 20, 2023 20:34
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jul 20, 2023
@backwaterred backwaterred marked this pull request as ready for review July 25, 2023 14:21
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2023
@backwaterred
Copy link
Contributor Author

backwaterred commented Jul 31, 2023

@tstuefe and others, I am looking for reviews on this PR if anyone has a moment.

@backwaterred backwaterred marked this pull request as draft July 31, 2023 21:40
@backwaterred
Copy link
Contributor Author

Rebased on current master branch to bring in current changes to #14964

@backwaterred backwaterred marked this pull request as ready for review July 31, 2023 21:42
@openjdk openjdk bot added rfr Pull request is ready for review and removed rfr Pull request is ready for review labels Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 9, 2023

@backwaterred This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312180: (bf) MappedMemoryUtils passes incorrect arguments to msync (aix)

Reviewed-by: clanger, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 107 new commits pushed to the master branch:

  • 83adaf5: 8313421: [JVMCI] avoid locking class loader in CompilerToVM.lookupType
  • 35b60f9: 8298095: Refine implSpec for SegmentAllocator
  • 6dba202: 8313670: Simplify shared lib name handling code in some tests
  • 8f28809: 8299790: os::print_hex_dump is racy
  • e080a0b: 8311508: ZGC: RAII use of IntelJccErratumAlignment
  • 242a2e6: 8308843: Generational ZGC: Remove gc/z/TestHighUsage.java
  • c822183: 8313768: Reduce interaction with volatile field in j.u.l.StreamHandler
  • cd16158: 8314075: Update JCov version for JDK 22
  • c307391: 8307184: Incorrect/inconsistent specification and implementation for Elements.getDocComment
  • 593ba2f: 8313693: Introduce an internal utility for the Damerau–Levenshtein distance calculation
  • ... and 97 more: https://git.openjdk.org/jdk/compare/c91a3002fb4304b6184d1d8d5611873c4e028af2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2023
Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The real question is whether you find any followup problems now that the illusion is partly broken.

Well, it had been broken before, hence the original issue :-/

@tstuefe
Copy link
Member

tstuefe commented Aug 10, 2023

@RealCLanger I would definitely run this through SAPs CI

@MBaesken
Copy link
Member

@RealCLanger I would definitely run this through SAPs CI

Hi Tyler / Thomas , I added the PR to our internal build/test queue .

@backwaterred
Copy link
Contributor Author

Thanks for the reviews @RealCLanger and @tstuefe, and thanks for adding this to the test queue @MBaesken

I'll wait to hear back for the results of the testing before proceeding.

@RealCLanger
Copy link
Contributor

Thanks for the reviews @RealCLanger and @tstuefe, and thanks for adding this to the test queue @MBaesken

I'll wait to hear back for the results of the testing before proceeding.

We have no results yet due to the build failure with XLC 17 from #14964. Could you please update that PR that we have a full test coverage? Thanks.

@backwaterred
Copy link
Contributor Author

@MBaesken @RealCLanger, looks like we're back in action (i.e. the build is fixed) w.r.t #14964. Could you try testing again?

@MBaesken
Copy link
Member

tests work nicely.

@backwaterred
Copy link
Contributor Author

Terrific news. Thanks for running the testing Matthias, and thanks the the reviews and feedback all.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 18, 2023

Going to push as commit fdac6a6.
Since your change was applied there have been 210 commits pushed to the master branch:

  • 7521211: 8314265: Fix -Wconversion warnings in miscellaneous runtime code
  • 2f04bc5: 8313697: [XWayland][Screencast] consequent getPixelColor calls are slow
  • 33d5dfd: 8314543: gitattributes: make diffs easier to read
  • 5058854: 8314389: AttachListener::pd_set_flag obsolete
  • 891c3f4: 8307356: Metaspace: simplify BinList handling
  • 0299364: 8314249: Refactor handling of invokedynamic in JVMCI ConstantPool
  • 96778dd: 8314169: Combine related RoundingMode logic in j.text.DigitList
  • 808bb1f: 8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux
  • 6445314: 8314477: Improve definition of "prototypical type"
  • d27daf0: 8314129: Make fields final in java.util.Scanner
  • ... and 200 more: https://git.openjdk.org/jdk/compare/c91a3002fb4304b6184d1d8d5611873c4e028af2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 18, 2023
@openjdk openjdk bot closed this Aug 18, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 18, 2023
@openjdk
Copy link

openjdk bot commented Aug 18, 2023

@backwaterred Pushed as commit fdac6a6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
4 participants