8312535: MidiSystem.getSoundbank() throws unexpected SecurityException

[mrserb]

• The doPrivileged block is added to fix SecurityException
• The usage of the property moved to static, now the "change" of the property at runtime will not affect the code

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312535: MidiSystem.getSoundbank() throws unexpected SecurityException (Bug - P3)

Reviewers

• Phil Race (@prrace - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14986/head:pull/14986
$ git checkout pull/14986

Update a local copy of the PR:
$ git checkout pull/14986
$ git pull https://git.openjdk.org/jdk.git pull/14986/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14986

View PR using the GUI difftool:
$ git pr show -t 14986

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14986.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (0d8ef6c1)

[openjdk]

@mrserb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312535: MidiSystem.getSoundbank() throws unexpected SecurityException

Reviewed-by: prr

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 288 new commits pushed to the master branch:

• 808bb1f: 8314246: javax/swing/JToolBar/4529206/bug4529206.java fails intermittently on Linux
• 6445314: 8314477: Improve definition of "prototypical type"
• d27daf0: 8314129: Make fields final in java.util.Scanner
• a8ab3be: 8314261: Make fields final in sun.net.www
• 3bb8afb: 8314489: Add javadoc index entries for java.lang.Math terms
• 2505ceb: 8314533: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all with ZGC
• b33ff30: 8313661: [REDO] Relax prerequisites for java.base-jmod target
• 62ca001: 8313357: Revisit requiring SA tests on OSX to either run as root or use sudo
• 388dcff: 8282712: VMConnection.open() does not detect if VM failed to be created, resulting in NPE
• e8f6b3e: 8314268: Missing include in assembler_riscv.hpp
• ... and 278 more: https://git.openjdk.org/jdk/compare/bfa76dffb5cbfb79f56d529be3b8756220d4a8d8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mrserb]

@prrace thank you! welcome back!

[mrserb]

/integrate

[openjdk]

Going to push as commit 87298d2.
Since your change was applied there have been 314 commits pushed to the master branch:

• 78f74bc: 8314672: ProblemList runtime/cds/appcds/customLoader/HelloCustom_JFR.java on linux-all and windows-x64
• 17a19dc: 8311639: Replace currentTimeMillis() with nanoTime() in jtreg/gc
• 0b3f452: 8314161: G1: Fix -Wconversion warnings in G1CardSetConfiguration::_bitmap_hash_mask
• abac608: 8313962: G1: Refactor G1ConcurrentMark::_num_concurrent_workers
• 812f475: 8314501: Shenandoah: sun/tools/jhsdb/heapconfig/JMapHeapConfigTest.java fails
• 8939d15: 8314100: G1: Improve collection set candidate selection code
• ec1f7a8: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview)
• c50315d: 8314495: Update to use jtreg 7.3.1
• ed0f75f: 8313290: Misleading exception message from STS.Subtask::get when task forked after shutdown
• febc34d: 8314610: hotspot can't compile with the latest of gtest because of
• ... and 304 more: https://git.openjdk.org/jdk/compare/bfa76dffb5cbfb79f56d529be3b8756220d4a8d8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@mrserb Pushed as commit 87298d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.