Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134" #14987

Closed
wants to merge 1 commit into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jul 23, 2023

Could I have a review of a fix that prevents the ChunkParser from locking up when an end time has been set.

The problem was likely introduced with https://bugs.openjdk.org/browse/JDK-8307738 where the condition for exiting the the while loop in ChunkParser::processRecursionSafe(...) was changed. What happens is that the awaitUpdatedHeader(...) method will return true when the end time exceeds the timestamp of the last segment. This leads to chunkFinished to be set to true and the loop in ChunkParser::processRecursionSafe(...) continues to next file, but there is no file so it spins forever in RepositoryFiles::updatePaths(...)

The fix is to allow the loop to exit when absoluteChunkEnd != chunkHeader.getEnd(), which will transfer control back to ChunkParser::processRecursionSafe(...) with chunkFinished set to false, where the method can return when the last segment has been fully parsed.

Just changing the return value from "true" to "false" would be incorrect. The stream should end when all the events leading up to the end time has been parsed, not just written.

Testing: 100 * test/jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134" (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14987/head:pull/14987
$ git checkout pull/14987

Update a local copy of the PR:
$ git checkout pull/14987
$ git pull https://git.openjdk.org/jdk.git pull/14987/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14987

View PR using the GUI difftool:
$ git pr show -t 14987

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14987.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2023

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed ou 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out Jul 23, 2023
@openjdk
Copy link

openjdk bot commented Jul 23, 2023

@egahlin The following label will be automatically applied to this pull request:

  • hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jul 23, 2023
@egahlin egahlin changed the title 8309871: jdk/jfr/api/consumer/recordingstream/TestSetEndTime.java timed out 8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134" Jul 23, 2023
@egahlin egahlin marked this pull request as ready for review July 24, 2023 08:25
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 24, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 24, 2023

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134"

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 7dd4799: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers
  • 197981b: 8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time
  • 04f39e1: 8310316: Failing HotSpot Compiler directives are too verbose
  • f3ade38: 8308593: Add Keepalive Extended Socket Options Support for Windows
  • ab821aa: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left
  • 0328886: 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 24, 2023
@egahlin
Copy link
Member Author

egahlin commented Jul 24, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Jul 24, 2023

Going to push as commit 3caf64e.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 298dda4: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • 7dd4799: 8311847: Fix -Wconversion for assembler.hpp emit_int8,16 callers
  • 197981b: 8311881: jdk/javax/swing/ProgressMonitor/ProgressTest.java does not show the ProgressMonitorInputStream all the time
  • 04f39e1: 8310316: Failing HotSpot Compiler directives are too verbose
  • f3ade38: 8308593: Add Keepalive Extended Socket Options Support for Windows
  • ab821aa: 6442919: JFilechooser popup still left-to-right when JFilechooser is set to right-to-left
  • 0328886: 8311955: c++filt is now ibm-llvm-cxxfilt when using xlc17 / clang on AIX

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 24, 2023
@openjdk openjdk bot closed this Jul 24, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 24, 2023
@openjdk
Copy link

openjdk bot commented Jul 24, 2023

@egahlin Pushed as commit 3caf64e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@egahlin
Copy link
Member Author

egahlin commented Aug 1, 2023

/backport jdk21u

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@egahlin the backport was successfully created on the branch egahlin-backport-3caf64e0 in my personal fork of openjdk/jdk21u. To create a pull request with this backport targeting openjdk/jdk21u:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit 3caf64e0 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 24 Jul 2023 and was reviewed by Markus Grönlund.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21u:

$ git fetch https://github.com/openjdk-bots/jdk21u.git egahlin-backport-3caf64e0:egahlin-backport-3caf64e0
$ git checkout egahlin-backport-3caf64e0
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21u.git egahlin-backport-3caf64e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
2 participants