Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312592: New parentheses warnings after HarfBuzz 7.2.0 update #14996

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 24, 2023

At least GCC 6 fail the build with warnings-as-errors here:

../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc: In function 'void _collect_layout_variation_indices(hb_subset_plan_t*)':
../src/java.desktop/share/native/libharfbuzz/hb-subset-plan.cc:389:83: error: suggest parentheses around assignment used as truth value [-Werror=parentheses]
     if (unlikely (!plan->check_success (font = _get_hb_font_with_variations (plan)))) {
                                                                                   ^
../src/java.desktop/share/native/libharfbuzz/hb.hh:259:46: note: in definition of macro 'unlikely'
 #define unlikely(expr) (__builtin_expect (!!(expr), 0))
                                              ^~~~

This is caused by HarfBuzz update to 7.2.0, JDK-8307301

Instead of fixing the HarfBuzz sources in-tree, it is cleaner to disable the warning. Lots of follow-ups after this HarfBuzz update did the same.

Additional testing:

  • Linux x86_64 fastdebug build on affected systems

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312592: New parentheses warnings after HarfBuzz 7.2.0 update (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14996/head:pull/14996
$ git checkout pull/14996

Update a local copy of the PR:
$ git checkout pull/14996
$ git pull https://git.openjdk.org/jdk.git pull/14996/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14996

View PR using the GUI difftool:
$ git pr show -t 14996

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14996.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 24, 2023
@openjdk
Copy link

openjdk bot commented Jul 24, 2023

@shipilev The following labels will be automatically applied to this pull request:

  • build
  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added build build-dev@openjdk.org client client-libs-dev@openjdk.org labels Jul 24, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2023

Webrevs

Copy link
Contributor

@prrace prrace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since gcc8 didn't complain about this, its probably just the older versions.

@openjdk
Copy link

openjdk bot commented Jul 24, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312592: New parentheses warnings after HarfBuzz 7.2.0 update

Reviewed-by: prr, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

  • d63bff6: 8312578: Redundant javadoc in X400Address
  • d0761c1: 8312077: Fix signed integer overflow, final part
  • 2bdfa83: 8262742: (fs) Add Path::resolve with varargs string
  • 8008e27: 8308903: Print detailed info for Java objects in -Xlog:cds+map
  • d8f2e9a: 8310530: PipedOutputStream.flush() accesses sink racily
  • fac9f88: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
  • d5c6b0d: 8311261: [AIX] TestAlwaysPreTouchStacks.java fails due to java.lang.RuntimeException: Did not find expected NMT output
  • d1cc278: 8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [i4] but found [I4]
  • 3caf64e: 8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134"
  • 298dda4: 8301457: Code in SendPortZero.java is uncommented even after JDK-8236852 was fixed
  • ... and 4 more: https://git.openjdk.org/jdk/compare/ab821aa24f248e042d367ccd908fc1f68ebe8333...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 24, 2023
@shipilev
Copy link
Member Author

Thanks for reviews! I am integrating to unblock some GCC 6 pipelines.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

Going to push as commit ea067fc.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 9999838: 8311646: ZGC: LIR_OpZStoreBarrier::_info shadows LIR_Op::_info
  • d63bff6: 8312578: Redundant javadoc in X400Address
  • d0761c1: 8312077: Fix signed integer overflow, final part
  • 2bdfa83: 8262742: (fs) Add Path::resolve with varargs string
  • 8008e27: 8308903: Print detailed info for Java objects in -Xlog:cds+map
  • d8f2e9a: 8310530: PipedOutputStream.flush() accesses sink racily
  • fac9f88: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
  • d5c6b0d: 8311261: [AIX] TestAlwaysPreTouchStacks.java fails due to java.lang.RuntimeException: Did not find expected NMT output
  • d1cc278: 8311822: AIX : test/jdk/java/foreign/TestLayouts.java fails because of different output - expected [i4] but found [I4]
  • 3caf64e: 8309238: jdk/jfr/tool/TestView.java failed with "exitValue = 134"
  • ... and 5 more: https://git.openjdk.org/jdk/compare/ab821aa24f248e042d367ccd908fc1f68ebe8333...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2023
@openjdk openjdk bot closed this Jul 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@shipilev Pushed as commit ea067fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants