Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312440: assert(cast != nullptr) failed: must have added a cast to pin the node #14999

Closed
wants to merge 1 commit into from

Conversation

rwestrel
Copy link
Contributor

@rwestrel rwestrel commented Jul 24, 2023

The test has a loop nest with 2 loops. A node is sunk out of the inner
loop. A cast is created to pin the node out of loop. The logic added
by 8308103 looks for an existing cast with the same inputs. It finds
one and uses that one. That existing cast was created before the
current round of loop opts. Eventhough it has the right out of inner
loop (but in outer loop) control input, it was assigned a control out
of both loops (the control is legal, it just happens that no use keeps
the cast in the outer loop). Next, the same node is sunk out of the
outer loop. The logic for sinking nodes looks for an input in the
outer loop (otherwise why would the node be in the outer loop) and
find none even though there should be one. The assert fires. The
reason is that the cast input has control out of loop. The fix I
propose is to not use an existing cast if it doesn't have the expected
control.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312440: assert(cast != nullptr) failed: must have added a cast to pin the node (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/14999/head:pull/14999
$ git checkout pull/14999

Update a local copy of the PR:
$ git checkout pull/14999
$ git pull https://git.openjdk.org/jdk.git pull/14999/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 14999

View PR using the GUI difftool:
$ git pr show -t 14999

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/14999.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 24, 2023

👋 Welcome back roland! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 24, 2023
@openjdk
Copy link

openjdk bot commented Jul 24, 2023

@rwestrel The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 24, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 24, 2023

Webrevs

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@rwestrel This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312440: assert(cast != nullptr) failed: must have added a cast to pin the node

Reviewed-by: chagedorn, kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

  • b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 36d578c: 8311653: Modify -XshowSettings launcher behavior
  • a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
  • 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
  • e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
  • 02a0473: 8312445: Array types in annotation elements show square brackets twice
  • c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
  • cc2a75e: 8312619: Strange error message when switching over long
  • ... and 43 more: https://git.openjdk.org/jdk/compare/3e8f1eb82039d4943abf79380f35ad1ec1927b45...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 25, 2023
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me too. Testing passed.

@rwestrel
Copy link
Contributor Author

@chhagedorn @vnkozlov @TobiHartmann thanks for the reviews

@rwestrel
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

Going to push as commit 01e135c.
Since your change was applied there have been 53 commits pushed to the master branch:

  • b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 36d578c: 8311653: Modify -XshowSettings launcher behavior
  • a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
  • 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
  • e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
  • 02a0473: 8312445: Array types in annotation elements show square brackets twice
  • c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
  • cc2a75e: 8312619: Strange error message when switching over long
  • ... and 43 more: https://git.openjdk.org/jdk/compare/3e8f1eb82039d4943abf79380f35ad1ec1927b45...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2023
@openjdk openjdk bot closed this Jul 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@rwestrel Pushed as commit 01e135c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
4 participants