Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257233: Windows x86 build is broken by JDK-8252684 #1500

Closed
wants to merge 1 commit into from

Conversation

@dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Nov 29, 2020

Moved the ifdef after the include of precompiled.hpp.

Awaiting GHA results.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build (8/8 running) ✔️ (2/2 passed) ✔️ (2/2 passed) (2/2 running) (1/2 running)
Test (tier1) (7/9 running)

Issue

  • JDK-8257233: Windows x86 build is broken by JDK-8252684

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1500/head:pull/1500
$ git checkout pull/1500

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 29, 2020

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Nov 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2020

@dholmes-ora To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Nov 29, 2020

/label add hotspot

@openjdk openjdk bot added the hotspot label Nov 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2020

@dholmes-ora
The hotspot label was successfully added.

vidmik
vidmik approved these changes Nov 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2020

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257233: Windows x86 build is broken by JDK-8252684

Reviewed-by: mikael

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Nov 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 29, 2020

Webrevs

@nick-arm
Copy link
Member

@nick-arm nick-arm commented Nov 29, 2020

Thanks for fixing this. Sorry I didn't check the windows build logs.

@dholmes-ora
Copy link
Member Author

@dholmes-ora dholmes-ora commented Nov 29, 2020

/integrate

@openjdk openjdk bot closed this Nov 29, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Nov 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 29, 2020

@dholmes-ora Pushed as commit 04eecf0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8257233 branch Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants