8312579: [JVMCI] JVMCI support for virtual Vector API objects

[gergo-]

Optimized Vector API values are represented as raw values in SIMD registers. When deoptimizing with such a value in the state, a Java heap object must be recreated. HotSpot has a special "Location::vector" location type to mark Vector API values, and it knows how to materialize such values.

Extend the JVMCI code installer to mark the appropriate values as vectors so that JVMCI-compiled code can also deoptimize with Vector API values in SIMD registers.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312579: [JVMCI] JVMCI support for virtual Vector API objects (Bug - P3)

Reviewers

• Doug Simon (@dougxc - Reviewer) ⚠️ Review applies to 5f183c27
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15003/head:pull/15003
$ git checkout pull/15003

Update a local copy of the PR:
$ git checkout pull/15003
$ git pull https://git.openjdk.org/jdk.git pull/15003/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15003

View PR using the GUI difftool:
$ git pr show -t 15003

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15003.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back gbarany! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@gergo- The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (bd9f0c8e)
• 02: Full - Incremental (3172dfe8)
• 01: Full - Incremental (87f81107)
• 00: Full (5f183c27)

[openjdk]

@gergo- This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312579: [JVMCI] JVMCI support for virtual Vector API objects

Reviewed-by: dnsimon, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 39 new commits pushed to the master branch:

• b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
• 36d578c: 8311653: Modify -XshowSettings launcher behavior
• a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
• 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
• 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
• 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
• e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
• 02a0473: 8312445: Array types in annotation elements show square brackets twice
• c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
• cc2a75e: 8312619: Strange error message when switching over long
• ... and 29 more: https://git.openjdk.org/jdk/compare/ab821aa24f248e042d367ccd908fc1f68ebe8333...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dougxc, @tkrodriguez) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[XiaohongGong]

Does it need to update #ifdef COMPILER2 to #if COMPILER2_OR_JVMCI in https://github.com/openjdk/jdk/blob/master/src/hotspot/share/runtime/deoptimization.cpp#L1238 which is the gateway of re-materializing a Vector API object from vector register/stack?

[dougxc]

Yes, I believe so. Gergo, you should scan all other code guarded by EnableVectorSupport to see if there's a similar problem.

[gergo-]

I updated all the relevant places guarded by EnableVectorSupport. Thank you for pointing this out @XiaohongGong .

[gergo-]

/integrate

[openjdk]

@gergo-
Your change (at version bd9f0c8) is now ready to be sponsored by a Committer.

[dougxc]

/sponsor

[openjdk]

Going to push as commit 271417a.
Since your change was applied there have been 43 commits pushed to the master branch:

• 44576a7: 8312466: /bin/nm usage in AIX makes needs -X64 flag
• 86821a7: 8312235: [JVMCI] ConstantPool should not force eager resolution
• 7cbab1f: 8312218: Print additional debug information when hitting assert(in_hash)
• 01e135c: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
• b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
• 36d578c: 8311653: Modify -XshowSettings launcher behavior
• a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
• 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
• 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
• 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
• ... and 33 more: https://git.openjdk.org/jdk/compare/ab821aa24f248e042d367ccd908fc1f68ebe8333...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc @gergo- Pushed as commit 271417a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.