Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8312620: WSL Linux build crashes after JDK-8310233 #15007

Conversation

tstuefe
Copy link
Member

@tstuefe tstuefe commented Jul 25, 2023

WSL exposes inconsistent information about hugepage support from proc fs, which makes the JVM assert. This patch makes the JVM instead avoid using hugepages for what is technically broken kernel behavior.

Testing: manually tested on a kernel where I faked the error we see on WSL.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312620: WSL Linux build crashes after JDK-8310233 (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15007/head:pull/15007
$ git checkout pull/15007

Update a local copy of the PR:
$ git checkout pull/15007
$ git pull https://git.openjdk.org/jdk.git pull/15007/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15007

View PR using the GUI difftool:
$ git pr show -t 15007

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15007.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2023

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@tstuefe The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 25, 2023
@djelinski
Copy link
Member

I can confirm that this fixes the WSL build issue.

You may need to change the @run line in the renamed test, otherwise jtreg will complain.

@tstuefe tstuefe force-pushed the JDK-8312620-WSL-Linux-build-crashes-after-JDK-8310233 branch from a8dfc6d to dac67bf Compare July 25, 2023 14:55
@tstuefe tstuefe marked this pull request as ready for review July 26, 2023 05:37
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2023

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be simpler to just set the default_static_huge_pagesize to zero in this case and effectively disable things that way?

@tstuefe
Copy link
Member Author

tstuefe commented Jul 26, 2023

Thanks for looking at this.

Would it be simpler to just set the default_static_huge_pagesize to zero in this case and effectively disable things that way?

I wanted a clear separation of layers. HugePages should be the interface to the machine settings, but not impose any decisions. So, for a broken kernel it should also expose the brokenness. The JVM then decides what to do with it in upper layers (os::large_page_init()).

This may sound artificial, but the Linux LP coding was long riddled with cross-layer-shortcuts and the JVM overruling the machine settings, such that it had been difficult to exactly see what's going on at a customer.

Besides making the coding clearer separated, it allows us to use HugePages::print_on to get an accurate reflection of the machine settings, usable for diagnostics, see also #14958 . I plan to slowly extend HugePages to expose other settings as well, e.g. the number of configured pages per hugepage pool; that can then replace some of the still existing sanity tests and for diagnostic printing.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay - seem fine then. Thanks

@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312620: WSL Linux build crashes after JDK-8310233

Reviewed-by: dholmes, djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 41 new commits pushed to the master branch:

  • 86821a7: 8312235: [JVMCI] ConstantPool should not force eager resolution
  • 7cbab1f: 8312218: Print additional debug information when hitting assert(in_hash)
  • 01e135c: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 36d578c: 8311653: Modify -XshowSettings launcher behavior
  • a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
  • 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
  • e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
  • ... and 31 more: https://git.openjdk.org/jdk/compare/f3ade388dac0b882e671462caa762138f44817fb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2023
@tstuefe
Copy link
Member Author

tstuefe commented Jul 27, 2023

Thanks @dholmes-ora and @djelinski !

/integrate

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

Going to push as commit 25058cd.
Since your change was applied there have been 45 commits pushed to the master branch:

  • 8661b8e: 8312495: assert(0 <= i && i < _len) failed: illegal index after JDK-8287061 on big endian platforms
  • 486c784: 8312433: HttpClient request fails due to connection being considered idle and closed
  • 271417a: 8312579: [JVMCI] JVMCI support for virtual Vector API objects
  • 44576a7: 8312466: /bin/nm usage in AIX makes needs -X64 flag
  • 86821a7: 8312235: [JVMCI] ConstantPool should not force eager resolution
  • 7cbab1f: 8312218: Print additional debug information when hitting assert(in_hash)
  • 01e135c: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 36d578c: 8311653: Modify -XshowSettings launcher behavior
  • a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • ... and 35 more: https://git.openjdk.org/jdk/compare/f3ade388dac0b882e671462caa762138f44817fb...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2023
@openjdk openjdk bot closed this Jul 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@tstuefe Pushed as commit 25058cd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants