Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312818: Incorrect format specifier in a HttpClient log message #15014

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Jul 25, 2023

Can I please get a review of this trivial fix to a log message in HttpClient? This addresses https://bugs.openjdk.org/browse/JDK-8312818.

After this change, the log message should correctly print messages like:

SelectorAttachment Registering jdk.internal.net.http.PlainHttpConnection$ConnectEvent@7513443c for C (true)

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312818: Incorrect format specifier in a HttpClient log message (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15014/head:pull/15014
$ git checkout pull/15014

Update a local copy of the PR:
$ git checkout pull/15014
$ git pull https://git.openjdk.org/jdk.git pull/15014/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15014

View PR using the GUI difftool:
$ git pr show -t 15014

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15014.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2023

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@jaikiran The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jul 25, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2023

Webrevs

Copy link
Member

@djelinski djelinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking care of this.

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312818: Incorrect format specifier in a HttpClient log message

Reviewed-by: djelinski

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • b35ccb2: 8312533: JFR: No message for JFR.view when data is missing
  • ea067fc: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
  • 9999838: 8311646: ZGC: LIR_OpZStoreBarrier::_info shadows LIR_Op::_info

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 25, 2023
@jaikiran
Copy link
Member Author

Thank you Daniel for the review.

tier2 testing passed. Given the trivial nature of this change, I'll go ahead and integrate this now.

@jaikiran
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

Going to push as commit 91fe032.
Since your change was applied there have been 4 commits pushed to the master branch:

  • bd09880: 8312512: sspi.cpp avoid some NULL checks related to free and delete
  • b35ccb2: 8312533: JFR: No message for JFR.view when data is missing
  • ea067fc: 8312592: New parentheses warnings after HarfBuzz 7.2.0 update
  • 9999838: 8311646: ZGC: LIR_OpZStoreBarrier::_info shadows LIR_Op::_info

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2023
@openjdk openjdk bot closed this Jul 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@jaikiran Pushed as commit 91fe032.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
2 participants