8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg

[jaikiran]

Can I please get a review of this test-only change which removes usages of the deprecated (no-op) -Xdebug from these tests? I missed these files when addressing https://bugs.openjdk.org/browse/JDK-8227229.

tier testing with these changes has passed without issues.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg (Task - P4)

Reviewers

• Kevin Walls (@kevinjwalls - Committer)
• Chris Plummer (@plummercj - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15016/head:pull/15016
$ git checkout pull/15016

Update a local copy of the PR:
$ git checkout pull/15016
$ git pull https://git.openjdk.org/jdk.git pull/15016/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15016

View PR using the GUI difftool:
$ git pr show -t 15016

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15016.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@jaikiran The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9a88ab39)

[kevinjwalls]

Looks good.

[openjdk]

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg

Reviewed-by: kevinw, cjplummer, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• 117f42d: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased
• 2d05d35: 8312979: Fix assembler_aarch64.hpp after JDK-8311847
• 78a8a99: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++
• cb82c95: 8312415: Expand -Xlint:serial checks to enum constants with specialized class bodies
• c6396dc: 8039165: [Doc] MessageFormat null locale generates NullPointerException
• 36f3bae: 8312401: SymbolTable::do_add_if_needed hangs when called in InstanceKlass::add_initialization_error path with requesting length exceeds max_symbol_length
• e554fde: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
• 9606cbc: 8312524: [JVMCI] serviceability/dcmd/compiler/CompilerQueueTest.java fails
• 91fe032: 8312818: Incorrect format specifier in a HttpClient log message
• bd09880: 8312512: sspi.cpp avoid some NULL checks related to free and delete
• ... and 3 more: https://git.openjdk.org/jdk/compare/d63bff672feafc7df4b1324bf7acce105a998913...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[jaikiran]

Thank you Kevin and Chris for the reviews. Since this is serviceability area, I'll wait for one more Reviewer before integrating.

[dholmes-ora]

Looks fine but what about

./runtime/CommandLine/TestNullTerminatedFlags.java

?

Thanks

[jaikiran]

Thank you David for the review.

Looks fine but what about

./runtime/CommandLine/TestNullTerminatedFlags.java

I left this test untouched intentionally. The summary of that test says:

Test that the VM don't allow random junk characters at the end of valid command line flags.

Given that -Xdebug is still an accepted option, I think letting this test to continue running it against this option would be good. Once we completely remove that option, I think we can update this test.

[AlanBateman]

Given that -Xdebug is still an accepted option, I think letting this test to continue running it against this option would be good. Once we completely remove that option, I think we can update this test.

That come up in the other PR too and I think we agreed to leave this test unchanged. When -Xdebug is eventually removed then it can be removed from this test too.

[jaikiran]

/integrate

[openjdk]

Going to push as commit e9daf4a.
Since your change was applied there have been 13 commits pushed to the master branch:

• 117f42d: 8312625: Test serviceability/dcmd/vm/TrimLibcHeapTest.java failed: RSS use increased
• 2d05d35: 8312979: Fix assembler_aarch64.hpp after JDK-8311847
• 78a8a99: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++
• cb82c95: 8312415: Expand -Xlint:serial checks to enum constants with specialized class bodies
• c6396dc: 8039165: [Doc] MessageFormat null locale generates NullPointerException
• 36f3bae: 8312401: SymbolTable::do_add_if_needed hangs when called in InstanceKlass::add_initialization_error path with requesting length exceeds max_symbol_length
• e554fde: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
• 9606cbc: 8312524: [JVMCI] serviceability/dcmd/compiler/CompilerQueueTest.java fails
• 91fe032: 8312818: Incorrect format specifier in a HttpClient log message
• bd09880: 8312512: sspi.cpp avoid some NULL checks related to free and delete
• ... and 3 more: https://git.openjdk.org/jdk/compare/d63bff672feafc7df4b1324bf7acce105a998913...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran Pushed as commit e9daf4a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[dholmes-ora]

@jaikiran I had a vague recollection that test was mentioned previously but then couldn't find that mention. Fine either way.