8312909: C1 should not inline through interface calls with non-subtype receiver

[TobiHartmann]

This is a problem with C1 compiling an interface call with an invalid receiver (see TestInvokeinterfaceWithBadReceiverHelper):

    ldc	String "42";
    invokeinterface	InterfaceMethod MyInterface.get:"()Ljava/lang/String;",  1;

String does not implement MyInterface but Class Hierarchy Analysis determined that there is only one implementor of MyInterface:

class MyClass implements MyInterface {
    @Stable
    String field = "42";

    public String get() {
        return field;
    }    
}

C1 emits a receiver subtype check (that will obviously fail at runtime and trigger an IncompatibleClassChangeError) and proceeds with inlining the MyClass::get method on the String receiver. It then tries to fold a stable field load by loading it's value at compile time which asserts/fails because the String receiver does not have such a field. The fix is to bail out from inlining when we can statically determine that the receiver subtype check will always fail at runtime.

Thanks,
Tobias

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312909: C1 should not inline through interface calls with non-subtype receiver (Bug - P3)

Reviewers

• Vladimir Kozlov (@vnkozlov - Reviewer)
• Christian Hagedorn (@chhagedorn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15018/head:pull/15018
$ git checkout pull/15018

Update a local copy of the PR:
$ git checkout pull/15018
$ git pull https://git.openjdk.org/jdk.git pull/15018/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15018

View PR using the GUI difftool:
$ git pr show -t 15018

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15018.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (287f57ef)

[vnkozlov]

Good.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312909: C1 should not inline through interface calls with non-subtype receiver

Reviewed-by: kvn, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 97 new commits pushed to the master branch:

• c386091: 8312984: javac may crash on a record pattern with too few components
• 3212b64: 8313582: Problemlist failing test on linux x86
• bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
• 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
• 3c920f9: 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
• 53ca75b: 8313312: Add missing classpath exception copyright header
• 87d7e97: 8311031: JTable header border vertical lines are not aligned with data grid lines
• 8248e35: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0
• 6d180d5: 8313349: Introduce abstract void HtmlDocletWriter.buildPage()
• bc1d2ea: 8312821: Javac accepts char literal as template
• ... and 87 more: https://git.openjdk.org/jdk/compare/91fe03232760ae0a9b56456f2f5f5ee6e483e4ef...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[TobiHartmann]

Thanks, Vladimir!

[chhagedorn]

Looks good!

[TobiHartmann]

/integrate

[TobiHartmann]

Thanks for the review, Christian!

[openjdk]

Going to push as commit ab1c212.
Since your change was applied there have been 97 commits pushed to the master branch:

• c386091: 8312984: javac may crash on a record pattern with too few components
• 3212b64: 8313582: Problemlist failing test on linux x86
• bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
• 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
• 3c920f9: 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
• 53ca75b: 8313312: Add missing classpath exception copyright header
• 87d7e97: 8311031: JTable header border vertical lines are not aligned with data grid lines
• 8248e35: 8313576: GCC 7 reports compiler warning in bundled freetype 2.13.0
• 6d180d5: 8313349: Introduce abstract void HtmlDocletWriter.buildPage()
• bc1d2ea: 8312821: Javac accepts char literal as template
• ... and 87 more: https://git.openjdk.org/jdk/compare/91fe03232760ae0a9b56456f2f5f5ee6e483e4ef...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit ab1c212.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.