JDK-8312218: Print additional debug information when hitting assert(in_hash)

[enothum]

Since it can be hard to reproduce the hitting assert(in_hash), I have added additional debug information that is dumped when hitting the assert. Additional to the previous message, the current graph and the node causing the assertion failure will now be dumped.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312218: Print additional debug information when hitting assert(in_hash) (Enhancement - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15022/head:pull/15022
$ git checkout pull/15022

Update a local copy of the PR:
$ git checkout pull/15022
$ git pull https://git.openjdk.org/jdk.git pull/15022/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15022

View PR using the GUI difftool:
$ git pr show -t 15022

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15022.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back enothum! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@enothum The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (a90148c4)
• 00: Full (501ca4b9)

[enothum]

Added a new line between the graph and node dump for better readability

[chhagedorn]

Looks good!

Let's hope that it will help us the next time we hit that assert.

[openjdk]

@enothum This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312218: Print additional debug information when hitting assert(in_hash)

Reviewed-by: chagedorn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

• b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
• 36d578c: 8311653: Modify -XshowSettings launcher behavior
• a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
• 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
• 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
• 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
• e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
• 02a0473: 8312445: Array types in annotation elements show square brackets twice
• c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
• cc2a75e: 8312619: Strange error message when switching over long
• ... and 73 more: https://git.openjdk.org/jdk/compare/82612e27255e36d498dcd6700f3b7d264b420180...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@chhagedorn, @TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[TobiHartmann]

Looks good to me.

[enothum]

Thanks for the reviews!

[enothum]

/integrate

[openjdk]

@enothum
Your change (at version a90148c) is now ready to be sponsored by a Committer.

[TobiHartmann]

/sponsor

[openjdk]

Going to push as commit 7cbab1f.
Since your change was applied there have been 84 commits pushed to the master branch:

• 01e135c: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
• b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
• 36d578c: 8311653: Modify -XshowSettings launcher behavior
• a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
• 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
• 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
• 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
• e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
• 02a0473: 8312445: Array types in annotation elements show square brackets twice
• c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
• ... and 74 more: https://git.openjdk.org/jdk/compare/82612e27255e36d498dcd6700f3b7d264b420180...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann @enothum Pushed as commit 7cbab1f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.