Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312979: Fix assembler_aarch64.hpp after JDK-8311847 #15023

Closed
wants to merge 3 commits into from

Conversation

coleenp
Copy link
Contributor

@coleenp coleenp commented Jul 25, 2023

This passes linux-aarch64-debug. Waiting for GHA to see if it passes windows-aarch64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312979: Fix assembler_aarch64.hpp after JDK-8311847 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15023/head:pull/15023
$ git checkout pull/15023

Update a local copy of the PR:
$ git checkout pull/15023
$ git pull https://git.openjdk.org/jdk.git pull/15023/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15023

View PR using the GUI difftool:
$ git pr show -t 15023

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15023.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2023

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@coleenp The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 25, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 25, 2023

Webrevs

@coleenp
Copy link
Contributor Author

coleenp commented Jul 25, 2023

/label add hotspot-runtime

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@coleenp
The hotspot-runtime label was successfully added.

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312979: Fix assembler_aarch64.hpp after JDK-8311847

Reviewed-by: dlong

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 78a8a99: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++
  • cb82c95: 8312415: Expand -Xlint:serial checks to enum constants with specialized class bodies
  • c6396dc: 8039165: [Doc] MessageFormat null locale generates NullPointerException
  • 36f3bae: 8312401: SymbolTable::do_add_if_needed hangs when called in InstanceKlass::add_initialization_error path with requesting length exceeds max_symbol_length
  • e554fde: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • 9606cbc: 8312524: [JVMCI] serviceability/dcmd/compiler/CompilerQueueTest.java fails

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 25, 2023
@coleenp
Copy link
Contributor Author

coleenp commented Jul 25, 2023

Thanks for reviewing, Dean. The GHA are done and clean except windows-x64, which is still running. Since this change doesn't touch that and it's trivial, I'm going to check it in now.
/integrate

@openjdk
Copy link

openjdk bot commented Jul 25, 2023

Going to push as commit 2d05d35.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 78a8a99: 8312488: tools/jpackage/share/AppLauncherEnvTest.java fails with dynamically linked libstdc++
  • cb82c95: 8312415: Expand -Xlint:serial checks to enum constants with specialized class bodies
  • c6396dc: 8039165: [Doc] MessageFormat null locale generates NullPointerException
  • 36f3bae: 8312401: SymbolTable::do_add_if_needed hangs when called in InstanceKlass::add_initialization_error path with requesting length exceeds max_symbol_length
  • e554fde: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • 9606cbc: 8312524: [JVMCI] serviceability/dcmd/compiler/CompilerQueueTest.java fails

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 25, 2023
@openjdk openjdk bot closed this Jul 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 25, 2023
@openjdk
Copy link

openjdk bot commented Jul 25, 2023

@coleenp Pushed as commit 2d05d35.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@coleenp coleenp deleted the windows-cast branch July 25, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
2 participants