Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke #15034

Conversation

sormuras
Copy link
Member

@sormuras sormuras commented Jul 26, 2023

Problem list some JUnit-based tests in test/jdk/java/lang/invoke/MethodHandleProxies/ for the time being - until jtreg 7.3 with a fix for the underlying race condition is released. That fix is tracked via https://bugs.openjdk.org/browse/CODETOOLS-7903507


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15034/head:pull/15034
$ git checkout pull/15034

Update a local copy of the PR:
$ git checkout pull/15034
$ git pull https://git.openjdk.org/jdk.git pull/15034/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15034

View PR using the GUI difftool:
$ git pr show -t 15034

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15034.diff

Webrev

Link to Webrev Comment

…voke

Problem list some JUnit-based tests in test/jdk/java/lang/invoke
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2023

👋 Welcome back cstein! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2023
@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@sormuras To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@dholmes-ora
Copy link
Member

/label add core-libs

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 26, 2023
@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@dholmes-ora
The core-libs label was successfully added.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks.

@mlbridge
Copy link

mlbridge bot commented Jul 26, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@sormuras This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke

Reviewed-by: dholmes, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
  • cc2a75e: 8312619: Strange error message when switching over long
  • 1f81e5b: 8312229: Crash involving yield, switch and anonymous classes
  • e9daf4a: 8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2023
@sormuras
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 26, 2023

Going to push as commit e7726fb.
Since your change was applied there have been 5 commits pushed to the master branch:

  • 02a0473: 8312445: Array types in annotation elements show square brackets twice
  • c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
  • cc2a75e: 8312619: Strange error message when switching over long
  • 1f81e5b: 8312229: Crash involving yield, switch and anonymous classes
  • e9daf4a: 8312916: Remove remaining usages of -Xdebug from test/hotspot/jtreg

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 26, 2023
@openjdk openjdk bot closed this Jul 26, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 26, 2023
@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@sormuras Pushed as commit e7726fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sormuras sormuras deleted the 8313155-problem-list-junit-invoke-tests branch July 26, 2023 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants