Skip to content

8313174: Create fewer predictable port clashes in management tests #15039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jul 26, 2023

Specifically noticed on linux-aarch64, detection of port clashes by LocateRegistry.createRegistry(port) appears "racy".

Predictable port clashes can be avoided, tests that are likely to run at the same time should not choose the same port.

Why now? The RMI related parts are obviously fairly stable these days, as are the tests themselves.
Our OS version/host mix for testing may have changed. The problems I looked into were on ol8-aarch64.

It doesn't seem necessary to add complexities to the tests, or change LocateRegistry much at this point, when a simple change to the tests can avoid asking for so many port clashes.

test/jdk/javax/management/remote/mandatory/passwordAuthenticator/RMIPasswdAuthTest.java:            int port = 5800;  	// 5801 to 5820
test/jdk/javax/management/remote/mandatory/passwordAuthenticator/RMIAltAuthTest.java:            int port = 5800;	// 5821 to 5840
test/jdk/javax/management/remote/mandatory/socketFactories/RMISocketFactoriesTest.java:            int port = 5800;	// 5841 to 5860
test/jdk/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation1Test.java:            int port = 5800;	// 5861 to 5880
test/jdk/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation2Test.java:            int port = 5800;	// 5881 to 5900
test/jdk/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation3Test.java:            int port = 5800;	// 5901 to 5920


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313174: Create fewer predictable port clashes in management tests (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15039/head:pull/15039
$ git checkout pull/15039

Update a local copy of the PR:
$ git checkout pull/15039
$ git pull https://git.openjdk.org/jdk.git pull/15039/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15039

View PR using the GUI difftool:
$ git pr show -t 15039

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15039.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2023

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@kevinjwalls The following labels will be automatically applied to this pull request:

  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org jmx jmx-dev@openjdk.org labels Jul 26, 2023
@kevinjwalls kevinjwalls marked this pull request as ready for review July 26, 2023 11:24
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 26, 2023

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313174: Create fewer predictable port clashes in management tests

Reviewed-by: cjplummer, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • a9d21c6: 8313081: MonitoringSupport_lock should be unconditionally initialized after 8304074
  • 4c2e54f: 8309088: security/infra/java/security/cert/CertPathValidator/certification/AmazonCA.java fails
  • 830413f: 8313087: DerValue::toString should output a hex view of the values in byte array
  • 7412193: 4800398: (ch spec) Clarify Channels.newChannel(InputStream) spec
  • e7726fb: 8313155: Problem list some JUnit-based tests in test/jdk/java/lang/invoke
  • 02a0473: 8312445: Array types in annotation elements show square brackets twice
  • c22cadf: 8312526: Test dk/jfr/event/oldobject/TestHeapDeep.java failed: Could not find ChainNode
  • cc2a75e: 8312619: Strange error message when switching over long
  • 1f81e5b: 8312229: Crash involving yield, switch and anonymous classes

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2023
@kevinjwalls
Copy link
Contributor Author

Thanks Chris, thanks Alex!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

Going to push as commit 169b6e3.
Since your change was applied there have been 20 commits pushed to the master branch:

  • 8650026: 8310033: Clarify return value of Java Time compareTo methods
  • 25058cd: 8312620: WSL Linux build crashes after JDK-8310233
  • 8661b8e: 8312495: assert(0 <= i && i < _len) failed: illegal index after JDK-8287061 on big endian platforms
  • 486c784: 8312433: HttpClient request fails due to connection being considered idle and closed
  • 271417a: 8312579: [JVMCI] JVMCI support for virtual Vector API objects
  • 44576a7: 8312466: /bin/nm usage in AIX makes needs -X64 flag
  • 86821a7: 8312235: [JVMCI] ConstantPool should not force eager resolution
  • 7cbab1f: 8312218: Print additional debug information when hitting assert(in_hash)
  • 01e135c: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • b7545a6: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • ... and 10 more: https://git.openjdk.org/jdk/compare/e9daf4a0185b90762d2bdd38d86fe93b4822ea08...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2023
@openjdk openjdk bot closed this Jul 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@kevinjwalls Pushed as commit 169b6e3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants