-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8313174: Create fewer predictable port clashes in management tests #15039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313174: Create fewer predictable port clashes in management tests #15039
Conversation
👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into |
@kevinjwalls The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/jdk/javax/management/remote/mandatory/subjectDelegation/SubjectDelegation2Test.java
Outdated
Show resolved
Hide resolved
@kevinjwalls This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks Chris, thanks Alex! |
/integrate |
Going to push as commit 169b6e3.
Your commit was automatically rebased without conflicts. |
@kevinjwalls Pushed as commit 169b6e3. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Specifically noticed on linux-aarch64, detection of port clashes by LocateRegistry.createRegistry(port) appears "racy".
Predictable port clashes can be avoided, tests that are likely to run at the same time should not choose the same port.
Why now? The RMI related parts are obviously fairly stable these days, as are the tests themselves.
Our OS version/host mix for testing may have changed. The problems I looked into were on ol8-aarch64.
It doesn't seem necessary to add complexities to the tests, or change LocateRegistry much at this point, when a simple change to the tests can avoid asking for so many port clashes.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15039/head:pull/15039
$ git checkout pull/15039
Update a local copy of the PR:
$ git checkout pull/15039
$ git pull https://git.openjdk.org/jdk.git pull/15039/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15039
View PR using the GUI difftool:
$ git pr show -t 15039
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15039.diff
Webrev
Link to Webrev Comment