4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

[prsadhuk]

Adding buttons in a JToolBar after a JSeparator will push the button to the far right of the frame instead of just after the separator

This is because BasicSeparatorUI does not define a maximum size. This leads to the separator getting all the extra width.
Fix is made to limit the separator's maximum size to the preferred size of corresponding orientation (i.e. width for VERTICAL and height for HORIZONTAL)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge (Bug - P4)

Reviewers

• Tejesh R (@TejeshR13 - Committer) ⚠️ Review applies to 9c432732
• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Damon Nguyen (@DamonGuy - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15054/head:pull/15054
$ git checkout pull/15054

Update a local copy of the PR:
$ git checkout pull/15054
$ git pull https://git.openjdk.org/jdk.git pull/15054/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15054

View PR using the GUI difftool:
$ git pr show -t 15054

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15054.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

⚠️ @prsadhuk This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

[openjdk]

@prsadhuk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (bb46ee7c)
• 02: Full - Incremental (e023f6c6)
• 01: Full - Incremental (5fcf61ca)
• 00: Full (9c432732)

[mrserb]

please merge from the latest master, it may fix the GA testing.

[prsadhuk]

Its not too old from latest master and I dont see any conflict being raised with the master and the commits will be quashed and right changes are being highlighted so I dont see any issue with the PR

[mrserb]

Your master is from Jun 12, 2023

[prsadhuk]

So? But the changed file is not being conflicted with any latest change in repo...

[mrserb]

but the testing in your GA shows builds failures on 3 platforms this is not present in any other PR right now.

[prsadhuk]

That can be safely ignored...As per my previous PRs, there also some tests fails but is not related to the change being done and does not hamper when integrated...

[TejeshR13]

Fix is working as expected.

[openjdk]

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

4346610: Adding JSeparator to JToolBar "pushes" buttons added after separator to edge

Reviewed-by: tr, aivanov, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 630 new commits pushed to the master branch:

• 9c6eb67: 8313167: Update to use jtreg 7.3
• 380418f: 8295058: test/langtools/tools/javac 116 test classes uses com.sun.tools.classfile library
• 4726960: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
• bbbfa21: 8313880: Incorrect copyright header in jdk/java/foreign/TestFree.java after JDK-8310643
• 0bb6af3: 8313791: Fix just zPage.inline.hpp and xPage.inline.hpp
• 4b192a8: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly
• 0b4387e: 8310643: Misformatted copyright messages in FFM
• 538f955: 8313701: GHA: RISC-V should use the official repository for bootstrap
• 226cdc6: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
• dc01604: 8305636: Expand and clean up predicate classes and move them into separate files
• ... and 620 more: https://git.openjdk.org/jdk/compare/4d4706967d44b6908406818bb135f94130f373a0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[DamonGuy]

Tested this myself and looks good.

[prsadhuk]

/integrate

[openjdk]

Going to push as commit 2bd2fae.
Since your change was applied there have been 730 commits pushed to the master branch:

• 6a15860: 8314163: os::print_hex_dump prints incorrectly for big endian platforms and unit sizes larger than 1
• 6bf4a33: 8314242: Update applications/scimark/Scimark.java to accept VM flags
• bc8e9f4: 8311591: Add SystemModulesPlugin test case that splits module descriptors with new local variables defined by DedupSetBuilder
• 0f5e030: 8309335: Get rid of use of reflection to call Thread.isVirtual() in nsk/jdi/EventRequestManager/stepRequests/stepreq001t.java
• f66c73d: 8314166: Update googletest to v1.14.0
• f239954: 8310134: NMT: thread count in Thread section of VM.native_memory output confusing with virtual threads
• 2e8a0ab: 8314120: Add tests for FileDescriptor.sync
• 80809ef: 8314248: Remove HotSpotConstantPool::isResolvedDynamicInvoke
• 004651d: 8311557: [JVMCI] deadlock with JVMTI thread suspension
• 9ded868: 8314114: Fix -Wconversion warnings in os code, primarily linux
• ... and 720 more: https://git.openjdk.org/jdk/compare/4d4706967d44b6908406818bb135f94130f373a0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@prsadhuk Pushed as commit 2bd2fae.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.