Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313250: Exclude java/foreign/TestByteBuffer.java on AIX #15055

Closed
wants to merge 1 commit into from

Conversation

TOatGithub
Copy link
Contributor

@TOatGithub TOatGithub commented Jul 27, 2023

exclude java/foreign/TestByteBuffer on AIX until https://bugs.openjdk.org/browse/JDK-8309475 is fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313250: Exclude java/foreign/TestByteBuffer.java on AIX (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15055/head:pull/15055
$ git checkout pull/15055

Update a local copy of the PR:
$ git checkout pull/15055
$ git pull https://git.openjdk.org/jdk.git pull/15055/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15055

View PR using the GUI difftool:
$ git pr show -t 15055

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15055.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2023

👋 Welcome back TOatGithub! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title JDK-8313250 8313250: Exclude java/foreign/TestByteBuffer.java on AIX Jul 27, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@TOatGithub To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@TOatGithub
Copy link
Contributor Author

/label nio

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@TOatGithub
The nio label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jul 27, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@TOatGithub This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313250: Exclude java/foreign/TestByteBuffer.java on AIX

Reviewed-by: rriggs, clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RogerRiggs, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2023
Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial

@TOatGithub
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@TOatGithub
Your change (at version d389afd) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 27, 2023

Going to push as commit c05ba48.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 169b6e3: 8313174: Create fewer predictable port clashes in management tests

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2023
@openjdk openjdk bot closed this Jul 27, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 27, 2023
@openjdk
Copy link

openjdk bot commented Jul 27, 2023

@RealCLanger @TOatGithub Pushed as commit c05ba48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@@ -787,3 +787,8 @@ java/awt/event/MouseEvent/SpuriousExitEnter/SpuriousExitEnter.java 8254841 macos
java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java 8256289 windows-x64
java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java 8258103 linux-all
java/awt/Focus/FrameMinimizeTest/FrameMinimizeTest.java 8016266 linux-x64

############################################################################
# java/foreign
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The convention used in the comments on each section is to use the group name rather than the package name, in this case, it's jdk_foreign.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, we'll fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated nio nio-dev@openjdk.org
4 participants