8313207: Remove MetaspaceShared::_has_error_classes

[matias9927]

The field _has_error_classes has its value set and change but it is no longer checked after JDK-8240481. This patch removes all instances MetaspaceShared::_has_error_classes. Verified with tier 1-4 tests.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313207: Remove MetaspaceShared::_has_error_classes (Enhancement - P4)

Reviewers

• Calvin Cheung (@calvinccheung - Reviewer)
• Ioi Lam (@iklam - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15060/head:pull/15060
$ git checkout pull/15060

Update a local copy of the PR:
$ git checkout pull/15060
$ git pull https://git.openjdk.org/jdk.git pull/15060/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15060

View PR using the GUI difftool:
$ git pr show -t 15060

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15060.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back matsaave! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@matias9927 The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (1eb1e0a2)

[calvinccheung]

Looks good.

[openjdk]

@matias9927 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313207: Remove MetaspaceShared::_has_error_classes

Reviewed-by: ccheung, iklam

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• c27c877: 8302017: Allocate BadPaddingException only if it will be thrown
• c55d29f: 8312626: Resolve multiple definition of 'start_timer' when statically linking JDK native libraries with user code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[matias9927]

Thanks for the reviews @calvinccheung and @iklam!
/integrate

[openjdk]

Going to push as commit b60e0ad.
Since your change was applied there have been 21 commits pushed to the master branch:

• 408987e: 8313307: java/util/Formatter/Padding.java fails on some Locales
• 6fca289: 8313023: Return value corrupted when using CCS + isTrivial (mainline)
• f8c2b7f: 8313231: Redundant if statement in ZoneInfoFile
• 807ca2d: 8313316: Disable runtime/ErrorHandling/MachCodeFramesInErrorFile.java on ppc64le
• ad34be1: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction
• d6245b6: 8310268: RISC-V: misaligned memory access in String.Compare intrinsic
• 402cb6a: 8312201: Clean up common behavior in "page writers" and "member writers"
• 23755f9: 8312411: MessageFormat.formatToCharacterIterator() can be improved
• e2cb0bc: 8313204: Inconsistent order of sections in generated class documentation
• 4ae75ca: 8313253: Rename methods in javadoc Comparators class
• ... and 11 more: https://git.openjdk.org/jdk/compare/0ca2bfd77960a84486d10d910aa47b2aa9c14e22...master

Your commit was automatically rebased without conflicts.

[openjdk]

@matias9927 Pushed as commit b60e0ad.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.