8311989: Test java/lang/Thread/virtual/Reflection.java timed out

[AlanBateman]

This is a test only change to a test that exercises core reflection from virtual threads. One of the tests (testNewInstance6) uses a custom scheduler in setup to check that calling a constructor reflectively, where the constructor parks, doesn't pin the underlying carrier. The test schedules an unpark from a virtual thread but the test is missing a call to Thread::join, thus creating a race between shutdown of the scheduler and the unpark. Two sightings of the test failing so far, both -Xcomp and ZGC.

While in the area, two usages of Thread.sleep in the test have been replaced with latches.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8311989: Test java/lang/Thread/virtual/Reflection.java timed out (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Mandy Chung (@mlchung - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15073/head:pull/15073
$ git checkout pull/15073

Update a local copy of the PR:
$ git checkout pull/15073
$ git pull https://git.openjdk.org/jdk.git pull/15073/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15073

View PR using the GUI difftool:
$ git pr show -t 15073

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15073.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back alanb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@AlanBateman The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8585372a)

[jaikiran]

The change looks good to me.

[openjdk]

@AlanBateman This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311989: Test java/lang/Thread/virtual/Reflection.java timed out

Reviewed-by: jpai, mchung

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

• e47a84f: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
• 78f6799: 8293972: runtime/NMT/NMTInitializationTest.java#default_long-off failed with "Suspiciously long bucket chains in lookup table."
• 97b6883: 8295059: test/langtools/tools/javap 12 test classes use com.sun.tools.classfile library
• 3671d83: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns
• b60e0ad: 8313207: Remove MetaspaceShared::_has_error_classes
• 408987e: 8313307: java/util/Formatter/Padding.java fails on some Locales
• 6fca289: 8313023: Return value corrupted when using CCS + isTrivial (mainline)
• f8c2b7f: 8313231: Redundant if statement in ZoneInfoFile
• 807ca2d: 8313316: Disable runtime/ErrorHandling/MachCodeFramesInErrorFile.java on ppc64le
• ad34be1: 8312525: New test runtime/os/TestTrimNative.java#trimNative is failing: did not see the expected RSS reduction
• ... and 7 more: https://git.openjdk.org/jdk/compare/d9559f9b24ee76c074cefcaf256d11ef5a7cc5b7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[AlanBateman]

/integrate

[openjdk]

Going to push as commit 6faf05c.
Since your change was applied there have been 38 commits pushed to the master branch:

• 5d1b911: 8310311: Serial: move Generation::contribute_scratch to DefNewGeneration
• 9454b2b: 8312591: GCC 6 build failure after JDK-8280982
• 6a853bb: 8311821: Simplify ParallelGCThreadsConstraintFunc after CMS removal
• e8471f6: 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList
• 528596f: 8310991: missing @SInCE tags in java.xml
• f14245b: 8312814: Compiler crash when template processor type is a captured wildcard
• 9b55e9a: 8312572: JDK 21 RDP2 L10n resource files update
• 28be34c: 8313226: Redundant condition test in X509CRLImpl
• dc14247: 8309240: Array classes should be stored in dynamic CDS archive
• bf70777: 8312181: CDS dynamic dump crashes when verifying unlinked class from static archive
• ... and 28 more: https://git.openjdk.org/jdk/compare/d9559f9b24ee76c074cefcaf256d11ef5a7cc5b7...master

Your commit was automatically rebased without conflicts.

[openjdk]

@AlanBateman Pushed as commit 6faf05c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.