Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313256: Exclude failing multicast tests on AIX #15074

Closed
wants to merge 8 commits into from

Conversation

TOatGithub
Copy link
Contributor

@TOatGithub TOatGithub commented Jul 28, 2023

exclude multicast and related tests on AIX mentioned in https://bugs.openjdk.org/browse/JDK-8308807 until this is fixed.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313256: Exclude failing multicast tests on AIX (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15074/head:pull/15074
$ git checkout pull/15074

Update a local copy of the PR:
$ git checkout pull/15074
$ git pull https://git.openjdk.org/jdk.git pull/15074/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15074

View PR using the GUI difftool:
$ git pr show -t 15074

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15074.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2023

👋 Welcome back TOatGithub! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 28, 2023

@TOatGithub To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@TOatGithub
Copy link
Contributor Author

/label net

@openjdk openjdk bot added the net net-dev@openjdk.org label Jul 28, 2023
@openjdk
Copy link

openjdk bot commented Jul 28, 2023

@TOatGithub
The net label was successfully added.

@TOatGithub TOatGithub changed the title Exclude Multicast tests on AIX 8313256: Exclude Multicast tests on AIX Jul 28, 2023
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 28, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2023

Webrevs

@AlanBateman
Copy link
Contributor

AlanBateman commented Jul 28, 2023

Are the DatagramChannel tests passing on this platform? DatagramChannel supports multicasting.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Thomas,

seems okay mostly, small nits remain, see inline remarks.

BTW you can test this on AIX via jtreg -exclude:<problemlist file> -l <tests>. [1] I often do this since I keep getting the Problemlist syntax wrong.

Cheers, Thomas

[1] https://openjdk.org/jtreg/command-help.html

@@ -789,6 +793,7 @@ java/awt/FullScreen/TranslucentWindow/TranslucentWindow.java 8258103 linux-all
java/awt/Focus/FrameMinimizeTest/FrameMinimizeTest.java 8016266 linux-x64

############################################################################
# java/foreign

# jdk_foreign
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this hunk

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The heading on the sections are usually test group names so "jdk_foreign" is correct, but I don't know what this change is doing in this PR.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys for pointing this out to a newbie! Would you expect me to add a NOOP PR with correct labeling?
Regards
Thomas

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks guys for pointing this out to a newbie! Would you expect me to add a NOOP PR with correct labeling?
Regards
Thomas

You can if you want to. I'm unemotional :-)

If you do, you can mark it as "trivial" (as in, mention in the PR description its a "Trivial" change, which - when accepted by reviewers - means just one review is needed and it is exempt from the usual "wait 24hrs before pushing" rule.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So if @AlanBateman does not insist, I'd keep it as is and hopefully rember for next time ;-)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion either way. I think the main thing is that I suspect you'll need to exclude more tests as there are several tests for DatagramChannel that join multicast groups and some of these likely assume they can join an IPv4 multicast group when cases where the DatagramChannel is created with the no-arg open method (and IPv6 is enabled) or with the IPV6 protocol family.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've created https://bugs.openjdk.org/browse/JDK-8313404 to extract the fix for jdk_foreign from this PR. It's cleaner, also for backporting, although it incurs some process overhead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, please remove this part of the change.

test/jdk/ProblemList.txt Outdated Show resolved Hide resolved
@TOatGithub TOatGithub changed the title 8313256: Exclude Multicast tests on AIX 8313256: Exclude failing multicast tests on AIX Jul 31, 2023
@RealCLanger
Copy link
Contributor

Are the DatagramChannel tests passing on this platform? DatagramChannel supports multicasting.

We currently exclude these two tests on AIX in our private exclude list:
java/nio/channels/DatagramChannel/AfterDisconnect.java
java/nio/channels/DatagramChannel/SendReceiveMaxSize.java

We should probably add them here, too.

@AlanBateman
Copy link
Contributor

We should probably add them here, too.

java/nio/channels/DatagramChannel/SendReceiveMaxSize.java doesn't do multicasting but maybe it is excluded on that platform for some other reason? There are several DatagramChannel tests that do exercise multicast and I suspect they will fail on platforms that don't allow dual IPv4/IPv6 sockets to join IPv4 multicast groups.

@RealCLanger
Copy link
Contributor

We should probably add them here, too.

java/nio/channels/DatagramChannel/SendReceiveMaxSize.java doesn't do multicasting but maybe it is excluded on that platform for some other reason? There are several DatagramChannel tests that do exercise multicast and I suspect they will fail on platforms that don't allow dual IPv4/IPv6 sockets to join IPv4 multicast groups.

I checked. SendReceiveMaxSize times out, probably for some other reason. So it should not be excluded here. But AfterDisconnect fails due to the IPv4/IPv6 issue, so this fits here.

@TOatGithub
Copy link
Contributor Author

I can confirm this and will add DatagramChannel soon. SendReceiveMaxSize never returns from a native call to recvfrom...

@AlanBateman
Copy link
Contributor

I checked. SendReceiveMaxSize times out, probably for some other reason. So it should not be excluded here. But AfterDisconnect fails due to the IPv4/IPv6 issue, so this fits here.

That's fine. The tests that I expected to see listed are tests such as BasicMulticastTests, MulticastSendReceiveTests, AdaptorMulticasting and several others but maybe they are passing on this platform.

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@TOatGithub this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout patch-1
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Aug 1, 2023
@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Aug 1, 2023
Copy link
Contributor

@RealCLanger RealCLanger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@TOatGithub This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313256: Exclude failing multicast tests on AIX

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2023
@aixtools
Copy link

aixtools commented Aug 1, 2023

fyi: iirc, sendmaxsize stuff fails when it exceeds 4G in /tmp, asm by default, that is the size of /tmp on AIX systems configured by the ansible playbooks. There can be other issues - also resolved with the correct AIX settings (iirc, no settings for maxbuf, and max tcp and udp buffer sizes.

imho: correct to include the transfer size tests, but when they became 2x 2.1 G (which becomes 4.2G) - these tests failed until /tmp was increased to 5G.

Unlike many Linux systems, "rootvg" on AIX is several, interdependently sized filesystems.

@TOatGithub
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@TOatGithub
Your change (at version 415446b) is now ready to be sponsored by a Committer.

@RealCLanger
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

Going to push as commit 98a915a.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2023
@openjdk openjdk bot closed this Aug 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@RealCLanger @TOatGithub Pushed as commit 98a915a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@AlanBateman
Copy link
Contributor

I see this has been integrated, were you able to confirm that the DC multicast tests are passing on this platform?

@RealCLanger
Copy link
Contributor

Yes, the tests that we didn't exclude here seem to work. There are a few network related tests still excluded on AIX in SAP's test system but these seem to have different symptoms. We're working on analyzing these and if necessary report the issues in JBS.

@TOatGithub TOatGithub deleted the patch-1 branch September 4, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
5 participants