8313394: Array Elements in OldObjectSample event has the incorrect description

[tkiriyama]

With this fix, arrayElements attribute in OldObjectSample event will be -1 if the object is not an array.
Could anyone please review this fix?

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313394: Array Elements in OldObjectSample event has the incorrect description (Bug - P4)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15084/head:pull/15084
$ git checkout pull/15084

Update a local copy of the PR:
$ git checkout pull/15084
$ git pull https://git.openjdk.org/jdk.git pull/15084/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15084

View PR using the GUI difftool:
$ git pr show -t 15084

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15084.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back tkiriyama! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tkiriyama The following label will be automatically applied to this pull request:

• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (6a61e62c)
• 00: Full (7e584ed8)

[egahlin]

A better fix is probably to update the description to match the implementation and change the JMC GUI to display integer min value as N/A, similar to the jfr tool and RecordedObject::toString().

There may be code that already relies on the current behavior and the min value is used to indicate N/A elsewhere.

[tkiriyama]

Modifying the description is easier than the current fix.
If you are comfortable with the INT_MIN value being used, I agree with your suggestion. In that case, I will only fix the description and withdraw the submitted test in this pull request.
Do you know the workflow for changeing the JMC GUI?

[egahlin]

If you are comfortable with the INT_MIN value being used, I agree with your suggestion. In that case, I will only fix the description and withdraw the submitted test in this pull request.

Sounds good.

Do you know the workflow for changeing the JMC GUI?

There is a wiki page:
https://wiki.openjdk.org/display/jmc/Main
Filing a bug on JMC is probably the first step.

[tkiriyama]

Thank you for your advice. I modified the description to match the actual behavior.
After integrated this fix, I will report the issue on JMC.

[openjdk]

@tkiriyama This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313394: Array Elements in OldObjectSample event has the incorrect description

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 53 new commits pushed to the master branch:

• d60352e: 8311006: missing @SInCE info in jdk.xml.dom
• 4577147: 8313712: [BACKOUT] 8313632: ciEnv::dump_replay_data use fclose
• bb3aac6: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel
• 0f2fce7: 8313632: ciEnv::dump_replay_data use fclose
• ab1c212: 8312909: C1 should not inline through interface calls with non-subtype receiver
• c386091: 8312984: javac may crash on a record pattern with too few components
• 3212b64: 8313582: Problemlist failing test on linux x86
• bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
• 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
• 3c920f9: 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
• ... and 43 more: https://git.openjdk.org/jdk/compare/ad34be1f329edc8e7155983835cc70d733c014b8...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@egahlin) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[egahlin]

You may want to change the name of the bug so it says something about the incorrect description.

[tkiriyama]

I see. I fixed the titles of the bug issue and this pull request.

[tkiriyama]

/integrate

[openjdk]

@tkiriyama
Your change (at version 6a61e62) is now ready to be sponsored by a Committer.

[egahlin]

/sponsor

[openjdk]

Going to push as commit e8c325d.
Since your change was applied there have been 53 commits pushed to the master branch:

• d60352e: 8311006: missing @SInCE info in jdk.xml.dom
• 4577147: 8313712: [BACKOUT] 8313632: ciEnv::dump_replay_data use fclose
• bb3aac6: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel
• 0f2fce7: 8313632: ciEnv::dump_replay_data use fclose
• ab1c212: 8312909: C1 should not inline through interface calls with non-subtype receiver
• c386091: 8312984: javac may crash on a record pattern with too few components
• 3212b64: 8313582: Problemlist failing test on linux x86
• bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
• 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
• 3c920f9: 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
• ... and 43 more: https://git.openjdk.org/jdk/compare/ad34be1f329edc8e7155983835cc70d733c014b8...master

Your commit was automatically rebased without conflicts.

[openjdk]

@egahlin @tkiriyama Pushed as commit e8c325d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.