Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312204: unexpected else with statement causes compiler crash #15086

Closed
wants to merge 2 commits into from

Conversation

lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Jul 31, 2023

Compiling (erroneous) code like:

void main() {
    else ;
}

Leads to:

$ javac --enable-preview -source 22 /tmp/Test.java 
An exception has occurred in the compiler (22-internal). Please file a bug against the Java compiler via the Java bug reporting page (https://bugreport.java.com) after checking the Bug Database (https://bugs.java.com) for duplicates. Include your program, the following diagnostic, and the parameters passed to the Java compiler in your report. Thank you.
java.lang.AssertionError
        at jdk.compiler/com.sun.tools.javac.parser.VirtualParser$VirtualScanner.errPos(VirtualParser.java:151)
        at jdk.compiler/com.sun.tools.javac.parser.JavacParser.doRecover(JavacParser.java:3122)
...

The proposed solution is to implement the two corresponding errPos methods for VirtualScanner.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8312204: unexpected else with statement causes compiler crash (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15086/head:pull/15086
$ git checkout pull/15086

Update a local copy of the PR:
$ git checkout pull/15086
$ git pull https://git.openjdk.org/jdk.git pull/15086/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15086

View PR using the GUI difftool:
$ git pr show -t 15086

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15086.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2023

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 31, 2023
@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@lahodaj The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Jul 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2023

Webrevs

Copy link
Contributor

@vicente-romero-oracle vicente-romero-oracle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@openjdk
Copy link

openjdk bot commented Aug 7, 2023

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312204: unexpected else with statement causes compiler crash

Reviewed-by: vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 152 new commits pushed to the master branch:

  • 87a6acb: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md
  • 87b08b6: 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM
  • 83edffa: 8309663: test fails "assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe"
  • 1da82a3: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • 9c6eb67: 8313167: Update to use jtreg 7.3
  • 380418f: 8295058: test/langtools/tools/javac 116 test classes uses com.sun.tools.classfile library
  • 4726960: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • bbbfa21: 8313880: Incorrect copyright header in jdk/java/foreign/TestFree.java after JDK-8310643
  • 0bb6af3: 8313791: Fix just zPage.inline.hpp and xPage.inline.hpp
  • 4b192a8: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly
  • ... and 142 more: https://git.openjdk.org/jdk/compare/ab821aa24f248e042d367ccd908fc1f68ebe8333...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 7, 2023
Co-authored-by: Andrey Turbanov <turbanoff@gmail.com>
@lahodaj
Copy link
Contributor Author

lahodaj commented Aug 8, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 8, 2023

Going to push as commit a1115a7.
Since your change was applied there have been 152 commits pushed to the master branch:

  • 87a6acb: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md
  • 87b08b6: 8307408: Some jdk/sun/tools/jhsdb tests don't pass test JVM args to the debuggee JVM
  • 83edffa: 8309663: test fails "assert(check_alignment(result)) failed: address not aligned: 0x00000008baadbabe"
  • 1da82a3: 8313702: Update IANA Language Subtag Registry to Version 2023-08-02
  • 9c6eb67: 8313167: Update to use jtreg 7.3
  • 380418f: 8295058: test/langtools/tools/javac 116 test classes uses com.sun.tools.classfile library
  • 4726960: 8313779: RISC-V: use andn / orn in the MD5 instrinsic
  • bbbfa21: 8313880: Incorrect copyright header in jdk/java/foreign/TestFree.java after JDK-8310643
  • 0bb6af3: 8313791: Fix just zPage.inline.hpp and xPage.inline.hpp
  • 4b192a8: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly
  • ... and 142 more: https://git.openjdk.org/jdk/compare/ab821aa24f248e042d367ccd908fc1f68ebe8333...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 8, 2023
@openjdk openjdk bot closed this Aug 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@lahodaj Pushed as commit a1115a7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants