8313403: Remove unused 'mask' field from JFormattedTextField

[aivanov-jdk]

The private field mask is never used in JFormattedTextField.

I couldn't find any usages of the field, including JNI. Therefore, it is safe to remove.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313403: Remove unused 'mask' field from JFormattedTextField (Bug - P4)

Reviewers

• Phil Race (@prrace - Reviewer)
• Harshitha Onkar (@honkar-jdk - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15088/head:pull/15088
$ git checkout pull/15088

Update a local copy of the PR:
$ git checkout pull/15088
$ git pull https://git.openjdk.org/jdk.git pull/15088/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15088

View PR using the GUI difftool:
$ git pr show -t 15088

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15088.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (75e7f906)

[mrserb]

It was left there since the JFormattedTextField class is Serializable, and it is a kind of "public" API because it is mentioned in the serializable form of this class(I think so). See an example where I had to add the spec to the private fields via CSR: https://bugs.openjdk.org/browse/JDK-8252544

But the JFormattedTextField is part of the Swing where we intentionally added a statement "Serialized objects of this class will not be compatible with future Swing releases" So we can delete it but probably CSR will be needed, I am not sure.

[aivanov-jdk]

It was left there since the JFormattedTextField class is Serializable, and it is a kind of "public" API because it is mentioned in the serializable form of this class(I think so). See an example where I had to add the spec to the private fields via CSR: https://bugs.openjdk.org/browse/JDK-8252544

But the JFormattedTextField is part of the Swing where we intentionally added a statement "Serialized objects of this class will not be compatible with future Swing releases" So we can delete it but probably CSR will be needed, I am not sure.

None of the Swing components is present in the Serialized Form for Java 17.

However, the field is still part of a serialized object. If a CSR is required, it may not be worth the effort.

[mrserb]

It is better to check, if CSR is not necessary anymore at least for Swing, we can do some small cleanup here and there.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313403: Remove unused 'mask' field from JFormattedTextField

Reviewed-by: prr, honkar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 252 new commits pushed to the master branch:

• 7c169a4: 8312232: Remove sun.jvm.hotspot.runtime.VM.buildLongFromIntsPD()
• 2eae13c: 8214248: (fs) Files:mismatch spec clarifications
• ce1ded1: 8314749: Remove unimplemented _Copy_conjoint_oops_atomic
• 32bf468: 8314274: G1: Fix -Wconversion warnings around G1CardSetArray::_data
• eb06572: 8313408: Use SVG for BoxLayout example
• 20e9478: 8314426: runtime/os/TestTrimNative.java is failing on slow machines
• 69d900d: 8314730: GHA: Drop libfreetype6-dev transitional package in favor of libfreetype-dev
• f39fc0a: 8314738: Remove all occurrences of and support for @Revised
• 6b9df03: 8311240: Eliminate usage of testcases.jar from TestMetaSpaceLog.java
• 3e1b1bf: 8314688: VM build without C1 fails after JDK-8313372
• ... and 242 more: https://git.openjdk.org/jdk/compare/408987e1ca9a42db8019b1bd7e52f85607975dde...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[aivanov-jdk]

@prrace could you confirm, please? No CSR is required to remove an unused private field from classes in Swing because the specification for Swing classes states, “Serialized objects of this class will not be compatible with future Swing releases.”

I believe your approval means just that. I still want an additional confirmation to avoid any confusion.

It is to resolve @mrserb's concern raised above.

[bridgekeeper]

@aivanov-jdk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[aivanov-jdk]

@prrace could you confirm, please? No CSR is required to remove an unused private field from classes in Swing because the specification for Swing classes states, “Serialized objects of this class will not be compatible with future Swing releases.”

I believe your approval means just that. I still want an additional confirmation to avoid any confusion.

It is to resolve @mrserb's concern raised above.

I haven't gotten any reply…

The PR has two approvals now. If don't hear any objections, I'll integrate it in a day or two.

[prrace]

@prrace could you confirm, please? No CSR is required to remove an unused private field from classes in Swing because the specification for Swing classes states, “Serialized objects of this class will not be compatible with future Swing releases.”
I believe your approval means just that. I still want an additional confirmation to avoid any confusion.
It is to resolve @mrserb's concern raised above.

I haven't gotten any reply…

The PR has two approvals now. If don't hear any objections, I'll integrate it in a day or two.

Swing isn't serializable across releases, so I see no need for a CSR.

[aivanov-jdk]

Swing isn't serializable across releases, so I see no need for a CSR.

Thank you. That's what I thought.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit b65f4f7.
Since your change was applied there have been 698 commits pushed to the master branch:

• e3201d1: 8310631: test/jdk/sun/nio/cs/TestCharsetMapping.java is spuriously passing
• 9291b46: 8313804: JDWP support for -Djava.net.preferIPv6Addresses=system
• afa4833: 8271268: Fix Javadoc links for Stream.mapMulti
• 9688ec2: 8311823: JFR: Uninitialized EventEmitter::_thread_id field
• 0f77d25: 8315684: Parallelize sun/security/util/math/TestIntegerModuloP.java
• 311c746: 8316859: RISC-V: Disable detection of V through HWCAP
• 0f0c5b2: 8316648: jrt-fs.jar classes not reproducible between standard and bootcycle builds
• 3d6e775: 8316669: ImmutableOopMapSet destructor not called
• 837783c: 8316670: Remove effectively unused nmethodBucket::_count
• 89e068b: 8316556: Fix typos in java.desktop
• ... and 688 more: https://git.openjdk.org/jdk/compare/408987e1ca9a42db8019b1bd7e52f85607975dde...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit b65f4f7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.