8313368: (fc) FileChannel.size returns 0 on block special files

[bplb]

Reinstate header files so that BLKGETSIZE64 is defined on Linux.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313368: (fc) FileChannel.size returns 0 on block special files (Bug - P4)

Reviewers

• Vyom Tewari (@vyommani - Committer) ⚠️ Review applies to f2ec65c4
• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15092/head:pull/15092
$ git checkout pull/15092

Update a local copy of the PR:
$ git checkout pull/15092
$ git pull https://git.openjdk.org/jdk.git pull/15092/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15092

View PR using the GUI difftool:
$ git pr show -t 15092

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15092.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back bpb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[bplb]

The proposed fix was verified manually using the test attached to the issue.

[openjdk]

@bplb The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (52c2f41f)
• 00: Full (f2ec65c4)

[vyommani]

Looks OK to me, i tested at my Linux box(Ubuntu-22.0.4) and fix is working as expected.

[openjdk]

@bplb This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313368: (fc) FileChannel.size returns 0 on block special files

Reviewed-by: vtewari, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

• ec2f38f: 8313428: GHA: Bump GCC versions for July 2023 updates
• 98a915a: 8313256: Exclude failing multicast tests on AIX
• 94b50b7: 8313404: Fix section label in test/jdk/ProblemList.txt
• ee3e091: 8313249: Fix -Wconversion warnings in verifier code
• e36960e: 8312420: Integrate Graal's blender micro benchmark
• 0a3c6d6: 8280482: Window transparency bug on Linux
• c91a300: 8307312: Replace "int which" with "int cp_index" in constantPool
• 6af0af5: 8310913: Move ReferencedKeyMap to jdk.internal so it may be shared
• 86783b9: 8301996: Move field resolution information out of the cpCache

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bplb]

/integrate

[openjdk]

Going to push as commit 4ba81f6.
Since your change was applied there have been 26 commits pushed to the master branch:

• c1a3f14: 8312078: [PPC] JcmdScale.java Failing on AIX
• 6446792: 8312617: SIGSEGV in ConnectionGraph::verify_ram_nodes
• b093880: 8313322: RISC-V: implement MD5 intrinsic
• 19e2c8c: 8313593: Generational ZGC: NMT assert when the heap fails to expand
• 46fbedb: 8313402: C1: Incorrect LoadIndexed value numbering
• 6faf05c: 8311989: Test java/lang/Thread/virtual/Reflection.java timed out
• 5d1b911: 8310311: Serial: move Generation::contribute_scratch to DefNewGeneration
• 9454b2b: 8312591: GCC 6 build failure after JDK-8280982
• 6a853bb: 8311821: Simplify ParallelGCThreadsConstraintFunc after CMS removal
• e8471f6: 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList
• ... and 16 more: https://git.openjdk.org/jdk/compare/5362ec9c6e9123d00288497ac9d1879a2bb1ca64...master

Your commit was automatically rebased without conflicts.

[openjdk]

@bplb Pushed as commit 4ba81f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.