Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313428: GHA: Bump GCC versions for July 2023 updates #15093

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 31, 2023

Some GHA runs are now running into configuration problems after runner update. We need to bump the GCC versions to unbreak them.

Additional testing:

  • GHA

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313428: GHA: Bump GCC versions for July 2023 updates (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15093/head:pull/15093
$ git checkout pull/15093

Update a local copy of the PR:
$ git checkout pull/15093
$ git pull https://git.openjdk.org/jdk.git pull/15093/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15093

View PR using the GUI difftool:
$ git pr show -t 15093

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15093.diff

Webrev

Link to Webrev Comment

@shipilev shipilev marked this pull request as draft July 31, 2023 18:17
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 31, 2023

@shipilev The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Jul 31, 2023
@shipilev shipilev marked this pull request as ready for review July 31, 2023 19:49
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 31, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313428: GHA: Bump GCC versions for July 2023 updates

Reviewed-by: clanger, mbaesken, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2023
@shipilev
Copy link
Member Author

shipilev commented Aug 1, 2023

Note that RISC-V cross-build still fails due to bootstrapping errors, and should be fixed separately.

@shipilev
Copy link
Member Author

shipilev commented Aug 1, 2023

Thanks! Any more reviews, especially from build folks (@magicus, @erikj79)? I would like to integrate this to unbreak GHA testing.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not a build folk but looks good. Thanks for fixing.

@RealCLanger
Copy link
Contributor

Oracle build folks seem ooo atm. But I think this one should go in shortly to unbreak GHA.

@shipilev
Copy link
Member Author

shipilev commented Aug 1, 2023

All right then. (Puts on his own "I am actually in build group too" hat.)

/integrate

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

Going to push as commit ec2f38f.
Since your change was applied there have been 14 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2023
@openjdk openjdk bot closed this Aug 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@shipilev Pushed as commit ec2f38f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger
Copy link
Contributor

All right then. (Puts on his own "I am actually in build group too" hat.)

Matthias is in it, too. 😄

@shipilev shipilev deleted the JDK-8313428-gha-gcc-versions branch August 10, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
4 participants