Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem #15098

Closed
wants to merge 1 commit into from

Conversation

kumarabhi006
Copy link
Contributor

@kumarabhi006 kumarabhi006 commented Aug 1, 2023

VoiceOver doesn't announce anything for JRadioButtonMenuItem and JCheckBoxMenuItem when navigated with down arrow key. JRadioButtonMenuItem and JCheckBoxMenuItem are having an accessible role of RadioButton and CheckBox respectively and it is required to notify native side whenever they are selected.

Added the required fix and tested with SwingSet2 application. CI testing is also fine.

Fix can be tested with SwingSet2 application and test instructions are mentioned in JDK-8311160 description.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15098/head:pull/15098
$ git checkout pull/15098

Update a local copy of the PR:
$ git checkout pull/15098
$ git pull https://git.openjdk.org/jdk.git pull/15098/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15098

View PR using the GUI difftool:
$ git pr show -t 15098

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15098.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2023

👋 Welcome back abhiscxk! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@kumarabhi006 The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Aug 1, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2023

Webrevs

Copy link
Contributor

@savoptik savoptik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NikitkoCent please review.

Copy link
Member

@azuev-java azuev-java left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@kumarabhi006 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem

Reviewed-by: asemenov, kizune

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 303 new commits pushed to the master branch:

  • d60352e: 8311006: missing @SInCE info in jdk.xml.dom
  • 4577147: 8313712: [BACKOUT] 8313632: ciEnv::dump_replay_data use fclose
  • bb3aac6: 8301606: JFileChooser file chooser details view "size" label cut off in Metal Look&Feel
  • 0f2fce7: 8313632: ciEnv::dump_replay_data use fclose
  • ab1c212: 8312909: C1 should not inline through interface calls with non-subtype receiver
  • c386091: 8312984: javac may crash on a record pattern with too few components
  • 3212b64: 8313582: Problemlist failing test on linux x86
  • bdac348: 8313602: increase timeout for jdk/classfile/CorpusTest.java
  • 58906bf: 4893524: Swing drop targets should call close() on transferred readers and streams
  • 3c920f9: 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target
  • ... and 293 more: https://git.openjdk.org/jdk/compare/d6578bff1c69ebc165fc9734e6503bd2d5d021c2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 4, 2023
@kumarabhi006
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2023

Going to push as commit c1f4595.
Since your change was applied there have been 318 commits pushed to the master branch:

  • 90d795a: 8313141: Missing check for os_thread type in os_windows.cpp
  • 6d18529: 8313795: Fix for JDK-8313564 breaks ppc and s390x builds
  • ad6e9e7: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry
  • b463c6d: 8311517: Add performance information to ArrayList javadoc
  • b2add96: 8159527: Collections mutator methods should all be marked as optional operations
  • 873d117: 8312623: SA add NestHost and NestMembers attributes when dumping class
  • 017e0c7: 8310388: Shenandoah: Auxiliary bitmap is not madvised for THP
  • f66cd50: 8313564: Fix -Wconversion warnings in classfile code
  • e8a37b9: 8313248: C2: setScopedValueCache intrinsic exposes nullptr pre-values to store barriers
  • 29f1d8e: 8313707: GHA: Bootstrap sysroots with --variant=minbase
  • ... and 308 more: https://git.openjdk.org/jdk/compare/d6578bff1c69ebc165fc9734e6503bd2d5d021c2...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2023
@openjdk openjdk bot closed this Aug 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2023
@openjdk
Copy link

openjdk bot commented Aug 7, 2023

@kumarabhi006 Pushed as commit c1f4595.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants