Skip to content

Conversation

@djelinski
Copy link
Member

@djelinski djelinski commented Aug 1, 2023

The issue linked to ProblemList entry was closed as duplicate of JDK-8307185, which was fixed. The ProblemList entry should be removed.

No failures in 30 test runs. Output of -Xcheck:jni clean.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList (Task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15099/head:pull/15099
$ git checkout pull/15099

Update a local copy of the PR:
$ git checkout pull/15099
$ git pull https://git.openjdk.org/jdk.git pull/15099/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15099

View PR using the GUI difftool:
$ git pr show -t 15099

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15099.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2023

👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8313507 8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@djelinski To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@djelinski
Copy link
Member Author

/label add security

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@djelinski
The security label was successfully added.

@djelinski djelinski marked this pull request as ready for review August 1, 2023 07:28
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 1, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@djelinski This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • e36960e: 8312420: Integrate Graal's blender micro benchmark

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2023
@djelinski
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2023

Going to push as commit e8471f6.
Since your change was applied there have been 12 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2023
@openjdk openjdk bot closed this Aug 2, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2023
@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@djelinski Pushed as commit e8471f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@djelinski djelinski deleted the pkcs11-problemlist branch August 2, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants