-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8313507: Remove pkcs11/Cipher/TestKATForGCM.java from ProblemList #15099
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back djelinski! A progress list of the required criteria for merging this PR into |
|
@djelinski To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command. Applicable Labels
|
|
/label add security |
|
@djelinski |
|
@djelinski This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
/integrate |
|
Going to push as commit e8471f6.
Your commit was automatically rebased without conflicts. |
|
@djelinski Pushed as commit e8471f6. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The issue linked to ProblemList entry was closed as duplicate of JDK-8307185, which was fixed. The ProblemList entry should be removed.
No failures in 30 test runs. Output of
-Xcheck:jniclean.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15099/head:pull/15099$ git checkout pull/15099Update a local copy of the PR:
$ git checkout pull/15099$ git pull https://git.openjdk.org/jdk.git pull/15099/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15099View PR using the GUI difftool:
$ git pr show -t 15099Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15099.diff
Webrev
Link to Webrev Comment