-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8257238: Cleanup include directives for precompiled.hpp #1510
Conversation
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
@dholmes-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and trivial.
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Thanks Kim! /integrate |
@dholmes-ora Since your change was applied there has been 1 commit pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 222e943. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The precompiled header file is:
src/hotspot/share/precompiled/precompiled.hpp
The normal way to include precompiled headers is to just have:
#include "precompiled.hpp"
as the first directive in a file. This works because the makefiles set:
-I$(TOPDIR)/src/hotspot/share/precompiled
Some files instead have:
#include "precompiled/precompiled.hpp"
./os/bsd/semaphore_bsd.cpp
./os/linux/waitBarrier_linux.cpp
./os/posix/semaphore_posix.cpp
./os/posix/signals_posix.cpp
This should be trivially cleaned up.
Progress
Testing
Failed test task
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1510/head:pull/1510
$ git checkout pull/1510