/ jdk Public
8257238: Cleanup include directives for precompiled.hpp #1510
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge.
The precompiled header file is:
The normal way to include precompiled headers is to just have:
as the first directive in a file. This works because the makefiles set:
Some files instead have:
This should be trivially cleaned up.
Failed test task
$ git fetch https://git.openjdk.java.net/jdk pull/1510/head:pull/1510
$ git checkout pull/1510