Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257238: Cleanup include directives for precompiled.hpp #1510

Closed
wants to merge 1 commit into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Nov 30, 2020

The precompiled header file is:

src/hotspot/share/precompiled/precompiled.hpp

The normal way to include precompiled headers is to just have:

#include "precompiled.hpp"

as the first directive in a file. This works because the makefiles set:

-I$(TOPDIR)/src/hotspot/share/precompiled

Some files instead have:

#include "precompiled/precompiled.hpp"

./os/bsd/semaphore_bsd.cpp
./os/linux/waitBarrier_linux.cpp
./os/posix/semaphore_posix.cpp
./os/posix/signals_posix.cpp

This should be trivially cleaned up.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (8/8 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ❌ (1/2 failed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ⏳ (1/9 running)

Failed test task

Issue

  • JDK-8257238: Cleanup include directives for precompiled.hpp

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1510/head:pull/1510
$ git checkout pull/1510

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2020

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2020
@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Nov 30, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2020

Webrevs

Copy link

@kimbarrett kimbarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and trivial.

@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257238: Cleanup include directives for precompiled.hpp

Reviewed-by: kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • fdee70d: 8257237: Cleanup unused imports in the SunJSSE provider implementation

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2020
@dholmes-ora
Copy link
Member Author

Thanks Kim!

/integrate

@openjdk openjdk bot closed this Nov 30, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 30, 2020
@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@dholmes-ora Since your change was applied there has been 1 commit pushed to the master branch:

  • fdee70d: 8257237: Cleanup unused imports in the SunJSSE provider implementation

Your commit was automatically rebased without conflicts.

Pushed as commit 222e943.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dholmes-ora dholmes-ora deleted the 8257238 branch November 30, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants