Skip to content

Conversation

@RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Aug 1, 2023

JDK-8313250 introduced a new section in test/jdk/ProblemList.txt. It however used a label that didn't follow the standard convention. I also place the section before "Client manual tests".


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313404: Fix section label in test/jdk/ProblemList.txt (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15104/head:pull/15104
$ git checkout pull/15104

Update a local copy of the PR:
$ git checkout pull/15104
$ git pull https://git.openjdk.org/jdk.git pull/15104/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15104

View PR using the GUI difftool:
$ git pr show -t 15104

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15104.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@RealCLanger To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313404: Fix section label in test/jdk/ProblemList.txt

Reviewed-by: mbaesken, alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • ee3e091: 8313249: Fix -Wconversion warnings in verifier code

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 1, 2023
@RealCLanger
Copy link
Contributor Author

Integrating, as per trivial rule.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

Going to push as commit 94b50b7.
Since your change was applied there has been 1 commit pushed to the master branch:

  • ee3e091: 8313249: Fix -Wconversion warnings in verifier code

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 1, 2023
@openjdk openjdk bot closed this Aug 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 1, 2023
@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@RealCLanger Pushed as commit 94b50b7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RealCLanger RealCLanger deleted the fix-foreign-section branch August 1, 2023 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants