8312814: Compiler crash when template processor type is a captured wildcard

[JimLaskey]

Missing JCStringTemplate.processor translation in TransTypes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8312814: Compiler crash when template processor type is a captured wildcard (Bug - P2)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer) ⚠️ Review applies to 38bbc959
• Maurizio Cimadamore (@mcimadamore - Reviewer) ⚠️ Review applies to 38bbc959
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15107/head:pull/15107
$ git checkout pull/15107

Update a local copy of the PR:
$ git checkout pull/15107
$ git pull https://git.openjdk.org/jdk.git pull/15107/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15107

View PR using the GUI difftool:
$ git pr show -t 15107

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15107.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlaskey! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JimLaskey The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (a5ca1464)
• 01: Full - Incremental (38bbc959)
• 00: Full (c77ebe95)

[lahodaj]

Looks good to me.

[openjdk]

@JimLaskey This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312814: Compiler crash when template processor type is a captured wildcard

Reviewed-by: jlahoda, mcimadamore, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

• ec2f38f: 8313428: GHA: Bump GCC versions for July 2023 updates
• 98a915a: 8313256: Exclude failing multicast tests on AIX

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[mcimadamore]

Looks good!

[vicente-romero-oracle]

looks good

[JimLaskey]

/integrate

[openjdk]

Going to push as commit f14245b.
Since your change was applied there have been 7 commits pushed to the master branch:

• 9b55e9a: 8312572: JDK 21 RDP2 L10n resource files update
• 28be34c: 8313226: Redundant condition test in X509CRLImpl
• dc14247: 8309240: Array classes should be stored in dynamic CDS archive
• bf70777: 8312181: CDS dynamic dump crashes when verifying unlinked class from static archive
• 7ba8c69: 8312596: Null pointer access in Compile::TracePhase::~TracePhase after JDK-8311976
• ec2f38f: 8313428: GHA: Bump GCC versions for July 2023 updates
• 98a915a: 8313256: Exclude failing multicast tests on AIX

Your commit was automatically rebased without conflicts.

[openjdk]

@JimLaskey Pushed as commit f14245b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[JimLaskey]

/backport

[openjdk]

@JimLaskey Usage: /backport <repository> [<branch>]

[JimLaskey]

/backport jdk21 a5ca146

[openjdk]

@JimLaskey The target branch a5ca146453c509777acff075c39ad5b31e018cce does not exist

[JimLaskey]

/backport jdk21

[openjdk]

@JimLaskey the backport was successfully created on the branch JimLaskey-backport-f14245b3 in my personal fork of openjdk/jdk21. To create a pull request with this backport targeting openjdk/jdk21:master, just click the following link:

➡️ Create pull request

The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:

Hi all,

This pull request contains a backport of commit f14245b3 from the openjdk/jdk repository.

The commit being backported was authored by Jim Laskey on 2 Aug 2023 and was reviewed by Jan Lahoda, Maurizio Cimadamore and Vicente Romero.

Thanks!

If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk21:

$ git fetch https://github.com/openjdk-bots/jdk21.git JimLaskey-backport-f14245b3:JimLaskey-backport-f14245b3
$ git checkout JimLaskey-backport-f14245b3
# make changes
$ git add paths/to/changed/files
$ git commit --message 'Describe additional changes made'
$ git push https://github.com/openjdk-bots/jdk21.git JimLaskey-backport-f14245b3