Skip to content

8313564: Fix -Wconversion warnings in classfile code #15111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 14 commits into from
Closed

8313564: Fix -Wconversion warnings in classfile code #15111

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
6ea354b
Fix -Wconversion warnings in classfile code.
coleenp Jul 27, 2023
bfad5ce
Fix vmIntrinsics.cpp
coleenp Jul 28, 2023
830e836
Fix classLoader.cpp
coleenp Jul 28, 2023
8bd60e8
Fix systemDictionaryShared.cpp
coleenp Jul 28, 2023
e73ea64
Fix klassFactory.cpp
coleenp Jul 28, 2023
2d7b8ba
Fix fieldLayoutBuilder.cpp by fixing Contended command line parameter.
coleenp Jul 28, 2023
e488736
Fix loaderConstraints.cpp, altHashing.cpp, classLoaderExt.cpp
coleenp Jul 28, 2023
dd21775
Fix compactHashtable.cpp
coleenp Jul 31, 2023
3fa12be
unset Wconversion
coleenp Jul 31, 2023
0e97905
Missed a case that gets -Wconversion warning for ContendedPaddingWidt…
coleenp Aug 2, 2023
864a80f
David's suggestions.
coleenp Aug 3, 2023
4019e4e
Fix Atomic items_added code.
coleenp Aug 3, 2023
a092d42
Revert items_count change to int. Add check for items_count overflow…
coleenp Aug 3, 2023
9cfa3f3
Add %zu
coleenp Aug 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/hotspot/share/classfile/stringTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ oop StringTable::lookup_shared(const jchar* name, int len) {
void StringTable::allocate_shared_strings_array(TRAPS) {
assert(DumpSharedSpaces, "must be");
if (_items_count > (size_t)max_jint) {
fatal("Too many strings to be archived: " SIZE_FORMAT, _items_count);
fatal("Too many strings to be archived: %zu", _items_count);
}

int total = (int)_items_count;
Expand All @@ -825,7 +825,7 @@ void StringTable::allocate_shared_strings_array(TRAPS) {
// This can only happen if you have an extremely large number of classes that
// refer to more than 16384 * 16384 = 26M interned strings! Not a practical concern
// but bail out for safety.
log_error(cds)("Too many strings to be archived: " SIZE_FORMAT, _items_count);
log_error(cds)("Too many strings to be archived: %zu", _items_count);
MetaspaceShared::unrecoverable_writing_error();
}

Expand Down
2 changes: 1 addition & 1 deletion src/hotspot/share/classfile/symbolTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,7 +658,7 @@ void SymbolTable::copy_shared_symbol_table(GrowableArray<Symbol*>* symbols,

size_t SymbolTable::estimate_size_for_archive() {
if (_items_count > (size_t)max_jint) {
fatal("Too many symbols to be archived: " SIZE_FORMAT, _items_count);
fatal("Too many symbols to be archived: %zu", _items_count);
}
return CompactHashtableWriter::estimate_size(int(_items_count));
}
Expand Down