Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library #15112

Closed
wants to merge 31 commits into from

Conversation

xqoasis
Copy link
Contributor

@xqoasis xqoasis commented Aug 1, 2023

There are 144 tests to convert to the new Class-File API.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15112/head:pull/15112
$ git checkout pull/15112

Update a local copy of the PR:
$ git checkout pull/15112
$ git pull https://git.openjdk.org/jdk.git pull/15112/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15112

View PR using the GUI difftool:
$ git pr show -t 15112

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15112.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2023

👋 Welcome back xqoasis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 1, 2023

@xqoasis The following label will be automatically applied to this pull request:

  • compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the compiler compiler-dev@openjdk.org label Aug 1, 2023
@asotona
Copy link
Member

asotona commented Sep 1, 2023

It is huge piece of work and it looks good.
Thanks!

@xqoasis xqoasis marked this pull request as ready for review September 6, 2023 15:36
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2023

Webrevs

@xqoasis xqoasis changed the title 8313422: test/langtools/tools/javac 147 test classes uses com.sun.tools.classfile library 8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@xqoasis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313422: test/langtools/tools/javac 144 test classes uses com.sun.tools.classfile library

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 615 new commits pushed to the master branch:

  • 81f8c57: 8314632: Intra-case dominance check fails in the presence of a guard
  • b408a82: 8314260: Unable to load system libraries on Windows when using a SecurityManager
  • 726c9c9: 8315735: VerifyError when switch statement used with synchronized block
  • fd6442c: 8315602: Open source swing security manager test
  • e22eb06: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • 9887cd8: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
  • 8107eab: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • ab28300: 8315698: Crash when comparing BasicType as int after JDK-8310577
  • b05198a: 8315600: Open source few more headless Swing misc tests
  • 4127fbb: 8315606: Open source few swing text/html tests
  • ... and 605 more: https://git.openjdk.org/jdk/compare/8c9d091f19760deece8daf3e57add85482b9f2a7...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@asotona) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 7, 2023
@xqoasis
Copy link
Contributor Author

xqoasis commented Sep 7, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@xqoasis
Your change (at version 8a5f4c1) is now ready to be sponsored by a Committer.

@asotona
Copy link
Member

asotona commented Sep 7, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

Going to push as commit 8f7e29b.
Since your change was applied there have been 617 commits pushed to the master branch:

  • 8557205: 8312569: RISC-V: Missing intrinsics for Math.ceil, floor, rint
  • 2fd870a: 8315444: Convert test/jdk/tools to Classfile API
  • 81f8c57: 8314632: Intra-case dominance check fails in the presence of a guard
  • b408a82: 8314260: Unable to load system libraries on Windows when using a SecurityManager
  • 726c9c9: 8315735: VerifyError when switch statement used with synchronized block
  • fd6442c: 8315602: Open source swing security manager test
  • e22eb06: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • 9887cd8: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
  • 8107eab: 8314121: test tools/jpackage/share/RuntimePackageTest.java#id0 fails on RHEL8
  • ab28300: 8315698: Crash when comparing BasicType as int after JDK-8310577
  • ... and 607 more: https://git.openjdk.org/jdk/compare/8c9d091f19760deece8daf3e57add85482b9f2a7...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 7, 2023
@openjdk openjdk bot closed this Sep 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 7, 2023
@openjdk
Copy link

openjdk bot commented Sep 7, 2023

@asotona @xqoasis Pushed as commit 8f7e29b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler compiler-dev@openjdk.org integrated Pull request has been integrated
2 participants