-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8313274: [BACKOUT] Relax prerequisites for java.base-jmod target #15118
Conversation
This reverts commit 72501cf.
👋 Welcome back jpai! A progress list of the required criteria for merging this PR into |
tier1, tier2 and tier3 tests have passed with this change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backout looks good but please update the JBS issue as per:
https://openjdk.org/guide/#backing-out-a-change
Thanks.
@jaikiran This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 16 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Thank you David for the review and the pointer to the backout instructions. I've followed those instructions and updated this PR title as well the relevant JBS issues to track this backout. |
/integrate |
Going to push as commit 3c920f9.
Your commit was automatically rebased without conflicts. |
Can I please get a review of this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8313274?
The commit in this PR reverts the commit that was introduced in #14561. Martin, in the 8313274 JBS issue, notes that the failure started happening with that change.
The issue can be consistently reproduced using
--with-jobs=1
duringbash configure
and then triggering a build usingmake images
. After the revert of that commit, the build now passes with both--with-jobs=1
and without the--with-jobs
option (in which case it uses 8 jobs on my setup).The other PR where this commit was introduced noted that:
which I think meant that the change in that PR is mostly a good to have. Given that it does cause these unexpected failures, the proposal in this PR is to revert that change until we have a better way to do that change (if we want to do it).
tier testing is currently in progress with this change.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15118/head:pull/15118
$ git checkout pull/15118
Update a local copy of the PR:
$ git checkout pull/15118
$ git pull https://git.openjdk.org/jdk.git pull/15118/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 15118
View PR using the GUI difftool:
$ git pr show -t 15118
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15118.diff
Webrev
Link to Webrev Comment