Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313274: [BACKOUT] Relax prerequisites for java.base-jmod target #15118

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Aug 2, 2023

Can I please get a review of this change which proposes to fix https://bugs.openjdk.org/browse/JDK-8313274?

The commit in this PR reverts the commit that was introduced in #14561. Martin, in the 8313274 JBS issue, notes that the failure started happening with that change.

The issue can be consistently reproduced using --with-jobs=1 during bash configure and then triggering a build using make images. After the revert of that commit, the build now passes with both --with-jobs=1 and without the --with-jobs option (in which case it uses 8 jobs on my setup).

The other PR where this commit was introduced noted that:

Fixing this won't impact the build much, but certainly won't hurt either.

which I think meant that the change in that PR is mostly a good to have. Given that it does cause these unexpected failures, the proposal in this PR is to revert that change until we have a better way to do that change (if we want to do it).

tier testing is currently in progress with this change.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313274: [BACKOUT] Relax prerequisites for java.base-jmod target (Sub-task - P1)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15118/head:pull/15118
$ git checkout pull/15118

Update a local copy of the PR:
$ git checkout pull/15118
$ git pull https://git.openjdk.org/jdk.git pull/15118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15118

View PR using the GUI difftool:
$ git pr show -t 15118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15118.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 2, 2023

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 2, 2023
@openjdk
Copy link

openjdk bot commented Aug 2, 2023

@jaikiran The following label will be automatically applied to this pull request:

  • build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the build build-dev@openjdk.org label Aug 2, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 2, 2023

Webrevs

@jaikiran
Copy link
Member Author

jaikiran commented Aug 2, 2023

tier testing is currently in progress with this change.

tier1, tier2 and tier3 tests have passed with this change.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backout looks good but please update the JBS issue as per:
https://openjdk.org/guide/#backing-out-a-change
Thanks.

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313274: [BACKOUT] Relax prerequisites for java.base-jmod target

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated labels Aug 3, 2023
@jaikiran jaikiran changed the title 8313274: Failure building java.base-jmod target 8313274: [BACKOUT] Relax prerequisites for java.base-jmod target Aug 3, 2023
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 3, 2023
@jaikiran
Copy link
Member Author

jaikiran commented Aug 3, 2023

Thank you David for the review and the pointer to the backout instructions. I've followed those instructions and updated this PR title as well the relevant JBS issues to track this backout.
I'll go ahead and integrate this PR in the next hour or so.

@jaikiran
Copy link
Member Author

jaikiran commented Aug 3, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

Going to push as commit 3c920f9.
Since your change was applied there have been 16 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 3, 2023
@openjdk openjdk bot closed this Aug 3, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 3, 2023
@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@jaikiran Pushed as commit 3c920f9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build build-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants