Skip to content

8257398: Enhance debug output in Type::check_symmetrical #1513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

8257398: Enhance debug output in Type::check_symmetrical #1513

wants to merge 1 commit into from

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Nov 30, 2020 •
edited by openjdk bot
Loading

When working on C2 typesystem changes for project Valhalla, I got annoyed by always having to add debug information for the "meet not commutative" failure in Type::check_symmetrical. We should add output similar to the "meet not symmetric" case.

Thanks,
Tobias

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (8/8 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed) ✔️ (9/9 passed)

Issue

  • JDK-8257398: Enhance debug output in Type::check_symmetrical

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1513/head:pull/1513
$ git checkout pull/1513

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2020

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2020
@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Nov 30, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 30, 2020

Webrevs

iwanowww
iwanowww approved these changes Nov 30, 2020
View reviewed changes
Copy link
Contributor

@iwanowww iwanowww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Nov 30, 2020 •
edited
Loading

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257398: Enhance debug output in Type::check_symmetrical

Reviewed-by: vlivanov, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 962f7a3: 8257162: Initialize ThreadLocalAllocBuffer members
  • 337d7bc: 8257165: C2: Improve box elimination for vector masks and shuffles
  • 4e55d0f: 8257057: C2: Improve safepoint processing during vector scalarization pass
  • e77aed6: 8256754: Deoptimization::revoke_for_object_deoptimization: stack processing start call is redundant
  • 738efea: 8248564: JFR: Remote Recording Stream
  • 9bcd269: 8257221: C2: RegMask::is_bound_set split set handling broken since JDK-8221404

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 30, 2020
chhagedorn
chhagedorn approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@TobiHartmann
Copy link
Member Author

@iwanowww, @chhagedorn thanks for the reviews!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Dec 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2020
@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@TobiHartmann Since your change was applied there have been 26 commits pushed to the master branch:

  • f48737c: 8256254: Convert vmIntrinsics::ID to enum class
  • b5ce8af: 8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state
  • 0eaf0bb: 8257420: Zero VM build broken with clang after JDK-8256726 due to strlen() is not a constexpr
  • 822ee47: 8257242: [macOS] Java app crashes while switching input methods
  • 7d89852: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • 4356469: 8230501: Class data support for hidden classes
  • 11dad14: 8257445: (zipfs) Add DataProvider to TestLocOffsetFromZip64EF.java
  • 29f86e0: 8256536: Newer AMD 19h (EPYC) Processor family defaults
  • 7f58a8e: 8213719: Both sect163r2 and sect163k1 are default curves for field size 163
  • ae5b526: 8257448: Clean duplicated non-null check in the SunJSSE provider implementation
  • ... and 16 more: https://git.openjdk.java.net/jdk/compare/222e9430745323d06c9afb2cbaebb454e19c33e3...master

Your commit was automatically rebased without conflicts.

Pushed as commit 353e791.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwanowww iwanowww iwanowww approved these changes

@chhagedorn chhagedorn chhagedorn approved these changes

Assignees
No one assigned
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TobiHartmann @iwanowww @chhagedorn