Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly #15136

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 3, 2023

See the bug for the reasons. Basically, we want to target the intrinsic directly, to avoid the dependence on the JDK code shape.

Additional testing:

  • mainline: test is still sensitive to JDK-8313402 fix
  • 17u: test is now sensitive to JDK-8313402 fix

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15136/head:pull/15136
$ git checkout pull/15136

Update a local copy of the PR:
$ git checkout pull/15136
$ git pull https://git.openjdk.org/jdk.git pull/15136/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15136

View PR using the GUI difftool:
$ git pr show -t 15136

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15136.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 3, 2023
@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@shipilev The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Aug 3, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 3, 2023

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 3, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly

Reviewed-by: thartmann, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 26 new commits pushed to the master branch:

  • 0b4387e: 8310643: Misformatted copyright messages in FFM
  • 538f955: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • 226cdc6: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • dc01604: 8305636: Expand and clean up predicate classes and move them into separate files
  • a38fdaf: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.
  • c1f4595: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem
  • 90d795a: 8313141: Missing check for os_thread type in os_windows.cpp
  • 6d18529: 8313795: Fix for JDK-8313564 breaks ppc and s390x builds
  • ad6e9e7: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry
  • b463c6d: 8311517: Add performance information to ArrayList javadoc
  • ... and 16 more: https://git.openjdk.org/jdk/compare/c3860917346fb53ed3d23f11d112b58b8cd8448a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 3, 2023
@shipilev
Copy link
Member Author

shipilev commented Aug 4, 2023

Thanks! Any more reviewers, or is this trivial enough to go in?

@shipilev
Copy link
Member Author

shipilev commented Aug 7, 2023

Thanks! Any more reviewers, or is this trivial enough to go in?

Ping?

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@shipilev
Copy link
Member Author

shipilev commented Aug 7, 2023

Thank you!

/integrate

@openjdk
Copy link

openjdk bot commented Aug 7, 2023

Going to push as commit 4b192a8.
Since your change was applied there have been 26 commits pushed to the master branch:

  • 0b4387e: 8310643: Misformatted copyright messages in FFM
  • 538f955: 8313701: GHA: RISC-V should use the official repository for bootstrap
  • 226cdc6: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • dc01604: 8305636: Expand and clean up predicate classes and move them into separate files
  • a38fdaf: 8166900: If you wrap a JTable in a JLayer, the cursor is moved to the last row of table by you press the page down key.
  • c1f4595: 8311160: [macOS, Accessibility] VoiceOver: No announcements on JRadioButtonMenuItem and JCheckBoxMenuItem
  • 90d795a: 8313141: Missing check for os_thread type in os_windows.cpp
  • 6d18529: 8313795: Fix for JDK-8313564 breaks ppc and s390x builds
  • ad6e9e7: 8313554: Fix -Wconversion warnings for ResolvedFieldEntry
  • b463c6d: 8311517: Add performance information to ArrayList javadoc
  • ... and 16 more: https://git.openjdk.org/jdk/compare/c3860917346fb53ed3d23f11d112b58b8cd8448a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2023
@openjdk openjdk bot closed this Aug 7, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 7, 2023
@openjdk
Copy link

openjdk bot commented Aug 7, 2023

@shipilev Pushed as commit 4b192a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8313676-amend-test-load-indexed branch August 10, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants