Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257415: ZGC: Fix barrier_data types #1514

Closed
wants to merge 1 commit into from

Conversation

pliden
Copy link
Contributor

@pliden pliden commented Nov 30, 2020

The barrier_data is an uint8_t, but we sometimes pass it around as an int. With this patch we always treat it as an uint8_t.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Testing

Linux additional Linux x64 Linux x86 Windows x64 macOS x64
Build ✔️ (8/8 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed) ✔️ (2/2 passed)
Test (tier1) ✔️ (9/9 passed) ✔️ (9/9 passed) (1/9 failed) ✔️ (9/9 passed)

Failed test task

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1514/head:pull/1514
$ git checkout pull/1514

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 30, 2020

👋 Welcome back pliden! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@pliden The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Nov 30, 2020
@pliden pliden force-pushed the 8257415_fix_barrier_data_types branch from 38f3a09 to dd51a81 Compare Nov 30, 2020
@pliden pliden changed the title ZGC: Fix barrier_data types 8257415: ZGC: Fix barrier_data types Nov 30, 2020
@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 30, 2020
@pliden
Copy link
Contributor Author

pliden commented Nov 30, 2020

/cc hotspot-gc

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Nov 30, 2020
@openjdk
Copy link

openjdk bot commented Nov 30, 2020

@pliden
The hotspot-gc label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Nov 30, 2020

Webrevs

Copy link
Contributor

@stooart-mon stooart-mon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. (I'm not a reviewer).

stefank
stefank approved these changes Dec 1, 2020
@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@pliden This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8257415: ZGC: Fix barrier_data types

Reviewed-by: smonteith, stefank

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 24 new commits pushed to the master branch:

  • 3d460bd: 8256655: rework long counted loop handling
  • 13bd2e8: 8257396: AArch64 Zero build is broken after JDK-8252684
  • 353e791: 8257398: Enhance debug output in Type::check_symmetrical
  • f48737c: 8256254: Convert vmIntrinsics::ID to enum class
  • b5ce8af: 8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state
  • 0eaf0bb: 8257420: Zero VM build broken with clang after JDK-8256726 due to strlen() is not a constexpr
  • 822ee47: 8257242: [macOS] Java app crashes while switching input methods
  • 7d89852: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • 4356469: 8230501: Class data support for hidden classes
  • 11dad14: 8257445: (zipfs) Add DataProvider to TestLocOffsetFromZip64EF.java
  • ... and 14 more: https://git.openjdk.java.net/jdk/compare/337d7bce0334a8fdff030c10d9e2c5a8d72bf9b2...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 1, 2020
@pliden
Copy link
Contributor Author

pliden commented Dec 1, 2020

Thanks for reviewing!

/integrate

@openjdk openjdk bot closed this Dec 1, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2020
@openjdk
Copy link

openjdk bot commented Dec 1, 2020

@pliden Since your change was applied there have been 25 commits pushed to the master branch:

  • aa2d36f: 8256807: C2: Not marking stores correctly as mismatched in string opts
  • 3d460bd: 8256655: rework long counted loop handling
  • 13bd2e8: 8257396: AArch64 Zero build is broken after JDK-8252684
  • 353e791: 8257398: Enhance debug output in Type::check_symmetrical
  • f48737c: 8256254: Convert vmIntrinsics::ID to enum class
  • b5ce8af: 8256373: [Windows/HiDPI] The Frame#setBounds does not work in a minimized state
  • 0eaf0bb: 8257420: Zero VM build broken with clang after JDK-8256726 due to strlen() is not a constexpr
  • 822ee47: 8257242: [macOS] Java app crashes while switching input methods
  • 7d89852: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • 4356469: 8230501: Class data support for hidden classes
  • ... and 15 more: https://git.openjdk.java.net/jdk/compare/337d7bce0334a8fdff030c10d9e2c5a8d72bf9b2...master

Your commit was automatically rebased without conflicts.

Pushed as commit 021dced.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@pliden pliden deleted the 8257415_fix_barrier_data_types branch Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot hotspot-dev@openjdk.org hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
3 participants