Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313722: JFR: Avoid unnecessary calls to Events.from(Recording) #15147

Closed
wants to merge 3 commits into from

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Aug 4, 2023

Could I have a review of PR that removes unnecessary calls to Events.from(Recording).

With each call a new dump file is created. A better approach is store the events in a List that can be reused,

Testing: jdk/jdk/jfr

Thanks
Erik


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313722: JFR: Avoid unnecessary calls to Events.from(Recording) (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15147/head:pull/15147
$ git checkout pull/15147

Update a local copy of the PR:
$ git checkout pull/15147
$ git pull https://git.openjdk.org/jdk.git pull/15147/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15147

View PR using the GUI difftool:
$ git pr show -t 15147

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15147.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title 8313722: JFR: Avoid unnecessary calls to Events.from(Recording 8313722: JFR: Avoid unnecessary calls to Events.from(Recording) Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@egahlin The following label will be automatically applied to this pull request:

  • hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot hotspot-dev@openjdk.org label Aug 4, 2023
@egahlin egahlin marked this pull request as ready for review August 4, 2023 03:56
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2023

Webrevs

@egahlin
Copy link
Member Author

egahlin commented Aug 4, 2023

/label remove hotspot
/label add hotspot-jfr

@openjdk openjdk bot removed the hotspot hotspot-dev@openjdk.org label Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@egahlin
The hotspot label was successfully removed.

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@egahlin
The hotspot-jfr label was successfully added.

@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313722: JFR: Avoid unnecessary calls to Events.from(Recording)

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1538 new commits pushed to the master branch:

  • 92f7e51: 8312098: Update man page for javadoc
  • f6be7fd: 8321059: Unneeded array assignments in MergeCollation and CompactByteArray
  • d568562: 8320798: Console read line with zero out should zero out underlying buffer
  • 3087e14: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics
  • 54957ac: 8312560: Annotation on Decomposed Record Component in Enhanced For Loop Fails Compilation
  • 3b30095: 8321130: Microbenchmarks do not build any more after 8254693 on 32 bit platforms
  • 8f1d40b: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better
  • ecd335d: 8321107: Add more test cases for JDK-8319372
  • 2476be4: 8320716: ResolvedModule::reads includes self when configuration contains two or more automatic modules
  • 4ba94ef: 8320145: Compiler should accept final variable in Record Pattern
  • ... and 1528 more: https://git.openjdk.org/jdk/compare/d60352e26fd8b7e51eeaf299e3f88783b739b02a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2023

@egahlin This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 3, 2023

@egahlin This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Oct 3, 2023
@egahlin
Copy link
Member Author

egahlin commented Dec 1, 2023

/open

@openjdk openjdk bot reopened this Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@egahlin This pull request is now open

@egahlin
Copy link
Member Author

egahlin commented Dec 1, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Dec 1, 2023

Going to push as commit 3a09a05.
Since your change was applied there have been 1540 commits pushed to the master branch:

  • 42af8ce: 8308614: Enabling JVMTI ClassLoad event slows down vthread creation by factor 10
  • 1839433: 8320941: Discuss receiver type handling
  • 92f7e51: 8312098: Update man page for javadoc
  • f6be7fd: 8321059: Unneeded array assignments in MergeCollation and CompactByteArray
  • d568562: 8320798: Console read line with zero out should zero out underlying buffer
  • 3087e14: 8320807: [PPC64][ZGC] C1 generates wrong code for atomics
  • 54957ac: 8312560: Annotation on Decomposed Record Component in Enhanced For Loop Fails Compilation
  • 3b30095: 8321130: Microbenchmarks do not build any more after 8254693 on 32 bit platforms
  • 8f1d40b: 8321114: Rename "Unnamed Classes" to "Implicitly Declared Classes" better
  • ecd335d: 8321107: Add more test cases for JDK-8319372
  • ... and 1530 more: https://git.openjdk.org/jdk/compare/d60352e26fd8b7e51eeaf299e3f88783b739b02a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 1, 2023
@openjdk openjdk bot closed this Dec 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 1, 2023
@openjdk
Copy link

openjdk bot commented Dec 1, 2023

@egahlin Pushed as commit 3a09a05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
3 participants