Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8313768: Reduce interaction with volatile field in j.u.l.StreamHandler #15161

Closed
wants to merge 1 commit into from

Conversation

stsypanov
Copy link
Contributor

@stsypanov stsypanov commented Aug 4, 2023

In publish0(), flush0() and flushAndClose()methods of StreamHandler we read multiple times from volatile writer. The access number can be reduced by reading the field into local variable once.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8313768: Reduce interaction with volatile field in j.u.l.StreamHandler (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/15161/head:pull/15161
$ git checkout pull/15161

Update a local copy of the PR:
$ git checkout pull/15161
$ git pull https://git.openjdk.org/jdk.git pull/15161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 15161

View PR using the GUI difftool:
$ git pr show -t 15161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/15161.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 4, 2023

👋 Welcome back stsypanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 4, 2023
@openjdk
Copy link

openjdk bot commented Aug 4, 2023

@stsypanov The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Aug 4, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 4, 2023

Webrevs

Copy link
Member

@dfuch dfuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@stsypanov This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313768: Reduce interaction with volatile field in j.u.l.StreamHandler

Reviewed-by: dfuchs, jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

  • 3fb4805: 8307462: [REDO] VmObjectAlloc is not generated by intrinsics methods which allocate objects
  • 0a42c44: 8313954: Add gc logging to vmTestbase/vm/gc/containers/Combination05
  • 735b16a: 8313752: InstanceKlassFlags::print_on doesn't print the flag names
  • d3b578f: 8313345: SuperWord fails due to CMove without matching Bool pack
  • 31a307f: 8306441: Two phase segmented heap dump
  • 515add8: 8313206: PKCS11 tests silently skip execution
  • 6864441: 8313809: String template fails with java.lang.StringIndexOutOfBoundsException if last fragment is UTF16
  • 509f80b: 8313889: Fix -Wconversion warnings in foreign benchmarks
  • 5c3041c: 8313435: Clean up unused default methods code
  • 8752d49: 8313785: Fix -Wconversion warnings in prims code
  • ... and 30 more: https://git.openjdk.org/jdk/compare/29f1d8ef50e3b4b235177fd9642a1fcf26fe3bab...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 8, 2023
@stsypanov
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 8, 2023
@openjdk
Copy link

openjdk bot commented Aug 8, 2023

@stsypanov
Your change (at version cf5c276) is now ready to be sponsored by a Committer.

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me.

I have triggered a CI run and will sponsor once that completes (I don't expect any regressions here given the nature of this change).

@jaikiran
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 10, 2023

Going to push as commit c822183.
Since your change was applied there have been 54 commits pushed to the master branch:

  • cd16158: 8314075: Update JCov version for JDK 22
  • c307391: 8307184: Incorrect/inconsistent specification and implementation for Elements.getDocComment
  • 593ba2f: 8313693: Introduce an internal utility for the Damerau–Levenshtein distance calculation
  • 360f65d: 8314022: Problem-list tests failing with jtreg 7.3
  • 0eb0997: 8288936: Wrong lock ordering writing G1HeapRegionTypeChange JFR event
  • 19ae62a: 8311170: Simplify and modernize equals and hashCode in security area
  • e9f751a: 8311247: Some cpp files are compiled with -std:c11 flag
  • 213d3c4: 8313891: JFR: Incorrect exception message for RecordedObject::getInt
  • 0e2c72d: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
  • 52ec4bc: 8303056: Improve support for Unicode characters and digits in JavaDoc search
  • ... and 44 more: https://git.openjdk.org/jdk/compare/29f1d8ef50e3b4b235177fd9642a1fcf26fe3bab...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 10, 2023
@openjdk openjdk bot closed this Aug 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 10, 2023
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@jaikiran @stsypanov Pushed as commit c822183.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@stsypanov stsypanov deleted the 8313768 branch August 10, 2023 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
3 participants